Skip to content
Snippets Groups Projects
Commit 84bf1a65 authored by Thomas Woerner's avatar Thomas Woerner
Browse files

tasks_vault_members.yml: Use result.failed also for failed_when 

For failed_when result.failed should be used to make sure that
the task fails if there was an error.
parent 325c5bc3
Branches
Tags
No related merge requests found
Show whitespace changes
Inline Side-by-side
tests/vault/tasks_vault_members.yml
+ 32
− 32
View file @ 84bf1a65
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
name: "{{vault.name}}" name: "{{vault.name}}"
vault_type: "{{vault.vault_type}}" vault_type: "{{vault.vault_type}}"
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
when: vault.vault_type == 'standard' when: vault.vault_type == 'standard'
- name: Ensure vault is present - name: Ensure vault is present
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
vault_password: SomeVAULTpassword vault_password: SomeVAULTpassword
vault_type: "{{vault.vault_type}}" vault_type: "{{vault.vault_type}}"
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
when: vault.vault_type == 'symmetric' when: vault.vault_type == 'symmetric'
- name: Ensure vault is present - name: Ensure vault is present
...@@ -29,7 +29,7 @@ ...@@ -29,7 +29,7 @@
vault_type: "{{ vault.vault_type }}" vault_type: "{{ vault.vault_type }}"
public_key: "{{lookup('file', 'A_private.b64')}}" public_key: "{{lookup('file', 'A_private.b64')}}"
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
when: vault.vault_type == 'asymmetric' when: vault.vault_type == 'asymmetric'
- name: Ensure vault member user is present. - name: Ensure vault member user is present.
...@@ -40,7 +40,7 @@ ...@@ -40,7 +40,7 @@
users: users:
- user02 - user02
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault member user is present, again. - name: Ensure vault member user is present, again.
ipavault: ipavault:
...@@ -50,7 +50,7 @@ ...@@ -50,7 +50,7 @@
users: users:
- user02 - user02
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure more vault member users are present. - name: Ensure more vault member users are present.
ipavault: ipavault:
...@@ -61,7 +61,7 @@ ...@@ -61,7 +61,7 @@
- admin - admin
- user02 - user02
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault member user is still present. - name: Ensure vault member user is still present.
ipavault: ipavault:
...@@ -71,7 +71,7 @@ ...@@ -71,7 +71,7 @@
users: users:
- user02 - user02
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vault users are absent. - name: Ensure vault users are absent.
ipavault: ipavault:
...@@ -83,7 +83,7 @@ ...@@ -83,7 +83,7 @@
- user02 - user02
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault users are absent, again. - name: Ensure vault users are absent, again.
ipavault: ipavault:
...@@ -95,7 +95,7 @@ ...@@ -95,7 +95,7 @@
- user02 - user02
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vault user is absent, once more. - name: Ensure vault user is absent, once more.
ipavault: ipavault:
...@@ -106,7 +106,7 @@ ...@@ -106,7 +106,7 @@
- admin - admin
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vault member group is present. - name: Ensure vault member group is present.
ipavault: ipavault:
...@@ -115,7 +115,7 @@ ...@@ -115,7 +115,7 @@
action: member action: member
groups: vaultgroup groups: vaultgroup
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault member group is present, again. - name: Ensure vault member group is present, again.
ipavault: ipavault:
...@@ -124,7 +124,7 @@ ...@@ -124,7 +124,7 @@
action: member action: member
groups: vaultgroup groups: vaultgroup
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vault member group is absent. - name: Ensure vault member group is absent.
ipavault: ipavault:
...@@ -134,7 +134,7 @@ ...@@ -134,7 +134,7 @@
groups: vaultgroup groups: vaultgroup
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault member group is absent, again. - name: Ensure vault member group is absent, again.
ipavault: ipavault:
...@@ -144,7 +144,7 @@ ...@@ -144,7 +144,7 @@
groups: vaultgroup groups: vaultgroup
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vault member service is present. - name: Ensure vault member service is present.
ipavault: ipavault:
...@@ -153,7 +153,7 @@ ...@@ -153,7 +153,7 @@
action: member action: member
services: "HTTP/{{ ansible_facts['fqdn'] }}" services: "HTTP/{{ ansible_facts['fqdn'] }}"
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault member service is present, again. - name: Ensure vault member service is present, again.
ipavault: ipavault:
...@@ -162,7 +162,7 @@ ...@@ -162,7 +162,7 @@
action: member action: member
services: "HTTP/{{ ansible_facts['fqdn'] }}" services: "HTTP/{{ ansible_facts['fqdn'] }}"
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vault member service is absent. - name: Ensure vault member service is absent.
ipavault: ipavault:
...@@ -172,7 +172,7 @@ ...@@ -172,7 +172,7 @@
services: "HTTP/{{ ansible_facts['fqdn'] }}" services: "HTTP/{{ ansible_facts['fqdn'] }}"
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vault member service is absent, again. - name: Ensure vault member service is absent, again.
ipavault: ipavault:
...@@ -182,7 +182,7 @@ ...@@ -182,7 +182,7 @@
services: "HTTP/{{ ansible_facts['fqdn'] }}" services: "HTTP/{{ ansible_facts['fqdn'] }}"
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure user03 is an owner of vault. - name: Ensure user03 is an owner of vault.
ipavault: ipavault:
...@@ -191,7 +191,7 @@ ...@@ -191,7 +191,7 @@
owners: user03 owners: user03
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure user03 is an owner of vault, again. - name: Ensure user03 is an owner of vault, again.
ipavault: ipavault:
...@@ -200,7 +200,7 @@ ...@@ -200,7 +200,7 @@
owners: user03 owners: user03
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure user03 is not owner of vault. - name: Ensure user03 is not owner of vault.
ipavault: ipavault:
...@@ -210,7 +210,7 @@ ...@@ -210,7 +210,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure user03 is not owner of vault, again. - name: Ensure user03 is not owner of vault, again.
ipavault: ipavault:
...@@ -220,7 +220,7 @@ ...@@ -220,7 +220,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vaultgroup is an ownergroup of vault. - name: Ensure vaultgroup is an ownergroup of vault.
ipavault: ipavault:
...@@ -229,7 +229,7 @@ ...@@ -229,7 +229,7 @@
ownergroups: vaultgroup ownergroups: vaultgroup
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vaultgroup is an ownergroup of vault, again. - name: Ensure vaultgroup is an ownergroup of vault, again.
ipavault: ipavault:
...@@ -238,7 +238,7 @@ ...@@ -238,7 +238,7 @@
ownergroups: vaultgroup ownergroups: vaultgroup
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure vaultgroup is not ownergroup of vault. - name: Ensure vaultgroup is not ownergroup of vault.
ipavault: ipavault:
...@@ -248,7 +248,7 @@ ...@@ -248,7 +248,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure vaultgroup is not ownergroup of vault, again. - name: Ensure vaultgroup is not ownergroup of vault, again.
ipavault: ipavault:
...@@ -258,7 +258,7 @@ ...@@ -258,7 +258,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure service is an owner of vault. - name: Ensure service is an owner of vault.
ipavault: ipavault:
...@@ -267,7 +267,7 @@ ...@@ -267,7 +267,7 @@
ownerservices: "HTTP/{{ ansible_facts['fqdn'] }}" ownerservices: "HTTP/{{ ansible_facts['fqdn'] }}"
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure service is an owner of vault, again. - name: Ensure service is an owner of vault, again.
ipavault: ipavault:
...@@ -276,7 +276,7 @@ ...@@ -276,7 +276,7 @@
ownerservices: "HTTP/{{ ansible_facts['fqdn'] }}" ownerservices: "HTTP/{{ ansible_facts['fqdn'] }}"
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure service is not owner of vault. - name: Ensure service is not owner of vault.
ipavault: ipavault:
...@@ -286,7 +286,7 @@ ...@@ -286,7 +286,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure service is not owner of vault, again. - name: Ensure service is not owner of vault, again.
ipavault: ipavault:
...@@ -296,7 +296,7 @@ ...@@ -296,7 +296,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure {{vault.vault_type}} vault is absent - name: Ensure {{vault.vault_type}} vault is absent
ipavault: ipavault:
...@@ -304,7 +304,7 @@ ...@@ -304,7 +304,7 @@
name: "{{vault.name}}" name: "{{vault.name}}"
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure {{vault.vault_type}} vault is absent, again - name: Ensure {{vault.vault_type}} vault is absent, again
ipavault: ipavault:
...@@ -312,7 +312,7 @@ ...@@ -312,7 +312,7 @@
name: "{{vault.name}}" name: "{{vault.name}}"
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Cleanup testing environment. - name: Cleanup testing environment.
import_tasks: env_cleanup.yml import_tasks: env_cleanup.yml
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment