Skip to content
Snippets Groups Projects
Commit 8f2e96cb authored by Thomas Woerner's avatar Thomas Woerner
Browse files

ipaselfservice: Fix documentation sections and agument spec

ansible-test with ansible-2.14 is adding a lot of new tests to ensure
that the documentation section and the agument spec is complete. Needed
changes:

DOCUMENTATION section

- `type: str` needs to be set for string parameters
- `type: list` needs to be set for list parameters
- `elements: str` needs to be given for list of string parameters
- `required` tags need to be fixed according to the `argument_spec`
- `author` needs to be given with the github user also: `Name (@user)`

argument_spec

- `elements="str"` needs to be added to all list of string parameters

The `copyright` date is extended with `-2022`.
parent 07c8bb1e
No related branches found
No related tags found
No related merge requests found
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
# Authors: # Authors:
# Thomas Woerner <twoerner@redhat.com> # Thomas Woerner <twoerner@redhat.com>
# #
# Copyright (C) 2020 Red Hat # Copyright (C) 2020-2022 Red Hat
# see file 'COPYING' for use and warranty information # see file 'COPYING' for use and warranty information
# #
# This program is free software; you can redistribute it and/or modify # This program is free software; you can redistribute it and/or modify
...@@ -39,26 +39,36 @@ extends_documentation_fragment: ...@@ -39,26 +39,36 @@ extends_documentation_fragment:
options: options:
name: name:
description: The list of selfservice name strings. description: The list of selfservice name strings.
type: list
elements: str
required: true required: true
aliases: ["aciname"] aliases: ["aciname"]
permission: permission:
description: Permissions to grant (read, write). Default is write. description: Permissions to grant (read, write). Default is write.
type: list
elements: str
required: false required: false
aliases: ["permissions"] aliases: ["permissions"]
attribute: attribute:
description: Attribute list to which the selfservice applies description: Attribute list to which the selfservice applies
type: list
elements: str
required: false required: false
aliases: ["attrs"] aliases: ["attrs"]
action: action:
description: Work on selfservice or member level. description: Work on selfservice or member level.
type: str
choices: ["selfservice", "member"] choices: ["selfservice", "member"]
default: selfservice default: selfservice
required: false required: false
state: state:
description: The state to ensure. description: The state to ensure.
type: str
choices: ["present", "absent"] choices: ["present", "absent"]
default: present default: present
required: true required: false
author:
- Thomas Woerner (@t-woerner)
""" """
EXAMPLES = """ EXAMPLES = """
...@@ -130,13 +140,13 @@ def main(): ...@@ -130,13 +140,13 @@ def main():
ansible_module = IPAAnsibleModule( ansible_module = IPAAnsibleModule(
argument_spec=dict( argument_spec=dict(
# general # general
name=dict(type="list", aliases=["aciname"], default=None, name=dict(type="list", elements="str", aliases=["aciname"],
required=True), required=True),
# present # present
permission=dict(required=False, type='list', permission=dict(required=False, type='list', elements="str",
aliases=["permissions"], default=None), aliases=["permissions"], default=None),
attribute=dict(required=False, type='list', aliases=["attrs"], attribute=dict(required=False, type='list', elements="str",
default=None), aliases=["attrs"], default=None),
action=dict(type="str", default="selfservice", action=dict(type="str", default="selfservice",
choices=["member", "selfservice"]), choices=["member", "selfservice"]),
# state # state
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment