Skip to content
Snippets Groups Projects
Commit 9bf2def2 authored by Rafael Guterres Jeffman's avatar Rafael Guterres Jeffman
Browse files

hostgroup: Use IPAAnsibleModule method to validate arguments.

Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
parent c497c8c4
Branches
Tags
No related merge requests found
...@@ -224,6 +224,7 @@ def main(): ...@@ -224,6 +224,7 @@ def main():
# Check parameters # Check parameters
invalid = []
if state == "present": if state == "present":
if len(names) != 1: if len(names) != 1:
ansible_module.fail_json( ansible_module.fail_json(
...@@ -231,11 +232,6 @@ def main(): ...@@ -231,11 +232,6 @@ def main():
invalid = ["rename"] invalid = ["rename"]
if action == "member": if action == "member":
invalid.extend(["description", "nomembers"]) invalid.extend(["description", "nomembers"])
for x in invalid:
if vars()[x] is not None:
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s'" % (x, action))
if state == "renamed": if state == "renamed":
if len(names) != 1: if len(names) != 1:
...@@ -249,11 +245,6 @@ def main(): ...@@ -249,11 +245,6 @@ def main():
"description", "nomembers", "host", "hostgroup", "description", "nomembers", "host", "hostgroup",
"membermanager_user", "membermanager_group" "membermanager_user", "membermanager_group"
] ]
for x in invalid:
if vars()[x] is not None:
ansible_module.fail_json(
msg="Argument '%s' can not be used with state '%s'" %
(x, state))
if state == "absent": if state == "absent":
if len(names) < 1: if len(names) < 1:
...@@ -262,11 +253,8 @@ def main(): ...@@ -262,11 +253,8 @@ def main():
invalid = ["description", "nomembers", "rename"] invalid = ["description", "nomembers", "rename"]
if action == "hostgroup": if action == "hostgroup":
invalid.extend(["host", "hostgroup"]) invalid.extend(["host", "hostgroup"])
for x in invalid:
if vars()[x] is not None: ansible_module.params_fail_used_invalid(invalid, state, action)
ansible_module.fail_json(
msg="Argument '%s' can not be used with state '%s'" %
(x, state))
# Init # Init
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment