Skip to content
Snippets Groups Projects
Commit e6f0eb23 authored by Thomas Woerner's avatar Thomas Woerner
Browse files

automember: Use execute_ipa_commands

execute_ipa_commands replces the check mode exit, the loop over the
generated commands and also in the member failure handling for modules
with member support.
parent 917b3b62
No related branches found
No related tags found
No related merge requests found
...@@ -390,29 +390,13 @@ def main(): ...@@ -390,29 +390,13 @@ def main():
commands.append([None, 'automember_rebuild', commands.append([None, 'automember_rebuild',
{"hosts": rebuild_hosts}]) {"hosts": rebuild_hosts}])
# Check mode exit # Execute commands
if ansible_module.check_mode:
ansible_module.exit_json(changed=len(commands) > 0, **exit_args)
for name, command, args in commands: changed = ansible_module.execute_ipa_commands(commands)
try:
if name is None:
result = ansible_module.ipa_command_no_name(command, args)
else:
result = ansible_module.ipa_command(command, name, args)
if "completed" in result:
if result["completed"] > 0:
changed = True
else:
changed = True
except Exception as ex:
ansible_module.fail_json(msg="%s: %s: %s" % (command, name,
str(ex)))
# result["failed"] is used only for INCLUDE_RE, EXCLUDE_RE # result["failed"] is used only for INCLUDE_RE, EXCLUDE_RE
# if entries could not be added that are already there and # if entries could not be added that are already there and
# it entries could not be removed that are not there. # if entries could not be removed that are not there.
# All other issues like invalid attributes etc. are handled # All other issues like invalid attributes etc. are handled
# as exceptions. Therefore the error section is not here as # as exceptions. Therefore the error section is not here as
# in other modules. # in other modules.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment