- Apr 29, 2022
-
-
Thomas Woerner authored
New idrange management module
-
Thomas Woerner authored
ipaautomountmap: Fix parameter evaluation.
-
- Apr 28, 2022
-
-
Rafael Guterres Jeffman authored
There is a new idrange management module placed in the plugins folder: plugins/modules/ipaidrange.py The idrange module allows to ensure presence and absence of idranges. Here is the documentation of the module: README-idrange.md New example playbooks have been added: playbooks/idrange/idrange-absent.yml playbooks/idrange/idrange-ad-posix-present.yml playbooks/idrange/idrange-ad-present.yml playbooks/idrange/idrange-present.yml New tests for the module can be found at: tests/idrange/test_idrange.yml tests/idrange/test_idrange_client_context.yml
-
- Apr 27, 2022
-
-
Rafael Guterres Jeffman authored
This patch fixes the error messages when an invalid number of 'mapname' are provided for states 'present' or 'absent'.
-
Rafael Guterres Jeffman authored
The usage of 'automountmapname' is required in all automount map IPA API calls, and this change ensures that the value is always set as an argument.
-
Thomas Woerner authored
ipatrust: fix range_type and test enhancement.
-
Thomas Woerner authored
module_utils: Fix comparison of elements not in IPA object.
-
Thomas Woerner authored
ipatrust: Set valid choices for trust_type.
-
- Apr 26, 2022
-
-
Rafael Guterres Jeffman authored
The ipatrust module was ignoring the value of `range_type`, which is required to allow for different types of idranges.
-
Rafael Guterres Jeffman authored
This patch applies several changes to the ipatrust test playbook: * Add externally defined parameters so execution in local trust environments can be configured. The available parameters are: * winserver_admin_password: the Administrator password for the AD server (default: 'SomeW1Npassword') * winserver_domain: the AD server domain (default: 'windows.local') * winserver realm: the AD server realm (by default, the uppercase version of winserver_domain) * ipaserver_domain: the FreeIPA server domain (default: 'ipa.test') * ipaserver_realm: the FreeIPA server realm (by default, the uppercase version of ipaserver_domain * Modify trust verification to check for the existence of the trust as it the output of `ipa trust-find`, instead of cheking for the number of items returned, as the number might vary. * Add idempotency tests by re-executing tasks and verifying that no change was performed. * Added tests to verify creation of trusts with different 'range_type'. * Use a Kerberos cache for shell scripts, and destroy it on exit. * Properly remove all `idrange` that might be created upon setting up a trust.
-
Rafael Guterres Jeffman authored
As the task is expected to fail, the AD realm name was modified to show the expected behavior more clearly.
-
Thomas Woerner authored
DNS forward policy: ensure consistency between module parameters.
-
Rafael Guterres Jeffman authored
This patch updates the ipatrust documentation about the 'trust_type' parameter, and changes one password to be similar to the standard passwords used in other modules.
-
Rafael Guterres Jeffman authored
Ensure only valid choices for trust_type ('ad') are available for the module parameter.
-
Rafael Guterres Jeffman authored
This change allows clearing automountmap 'description' attribute by passing an empty string ("") as the playbook parameter. New test cases were added to check this behavior.
-
Rafael Guterres Jeffman authored
Due to a change in 'ansible_freeipa_module.compare_args_ipa', playbook parameters using empty strings are correctly evaluated, and do not need to be removed before comparison is performed. A new test playbook, with tests for clearing attributes with an empty string ("") is available at: tests/user/test_user_empty_lists.yml
-
Rafael Guterres Jeffman authored
This change modifies the comparison of the retrieved IPA object and the provided arguments on ansible_freeipa_module.compare_args_ipa when the provider argument is an empty string. If an attribute is not available in 'ipa', its value is considered to be a list with an empty string (['']), possibly forcing the conversion of the 'args' attribute to a list for comparison. This allows, for example, the usage of empty strings which should compare as equals to inexistent attributes (None), as is done in IPA API.
-
Thomas Woerner authored
utils/new_module templates: Add missing password to example playbooks.
-
Thomas Woerner authored
Update module templates to current practices.
-
Thomas Woerner authored
ansible-lint: Identify env_*.yml and tasks_*.yml as task files.
-
- Apr 25, 2022
-
-
Rafael Guterres Jeffman authored
Failing to identify task files included by playbooks raised false positives when runnnig ansible lint. This change force ansible-lint to correctly identify YAML files named "env_*.yml" or "tasks_*.yml" as task files that are imported by other playbooks, and treat them accordingly.
-
- Apr 12, 2022
-
-
Rafael Guterres Jeffman authored
Modules ipadnsconfig and ipadnsforwardzone allow the setting of forward policy for zone forwarders, but the parameter names differ between the modules. This patch ensures that the same parameter names can be used in each module. To keep backwar compatibility in both modules, both `forward_policy` and `forwardpolicy` are now supported.
-
Rafael Guterres Jeffman authored
Add missing ipaadmin_password to example playbooks so new modules have all necessary fields set on basic files.
-
- Apr 07, 2022
-
-
Rafael Guterres Jeffman authored
Update README-group.md
-
- Apr 06, 2022
-
-
vjs2174 authored
Fixed issue #790 changed line 103 to be more accurate.
-
- Apr 05, 2022
-
-
Thomas Woerner authored
Ensure example playbooks have ipaadmin_password and it is the standard one.
-
Thomas Woerner authored
Update pylint to version 2.12.2
-
- Mar 30, 2022
-
-
Rafael Guterres Jeffman authored
Some example playbooks do not had the parameter `ipaadmin_password` set, and some had a different value than the standard value "SomeADMINpassword". This patch fixes this difference in all example playbooks.
-
Rafael Guterres Jeffman authored
-
- Mar 22, 2022
-
-
Rafael Guterres Jeffman authored
Update pylint version to the latest supported by Fedora 36.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
Newer versions of pylint warns about not using f-strings, but those are not supported in Python 2, which ansible-freeipa still need to support.
-
- Mar 03, 2022
-
-
Varun Mylaraiah authored
module_params_get*: Fail on empty string in string list parameters
-
- Feb 28, 2022
-
-
Rafael Guterres Jeffman authored
automember: Remove debug output
-
Thomas Woerner authored
The warn debug line was added with "Add automember default group handling" d2648b14
-
Thomas Woerner authored
The parameters user_auth_type, pac_type and configstring are allowing to use "" to reset to the default value or for configstring to set an empty list. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. Additionally empty pac_type, user_auth_type and domain_resolution_order have been added to exit_args as if they have not been set.
-
- Feb 25, 2022
-
-
Thomas Woerner authored
The parameter auth_ind is allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working.
-
Thomas Woerner authored
The parameters auth_ind and pac_type are allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. An idempotency issue with pac_type has been found with the test and fixed additionally.
-
- Feb 24, 2022
-
-
Thomas Woerner authored
The parameters userauthtype and sshpubkey allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. An idempotency issue with sshpubkey has been found with the test and fixed additionally.
-
Thomas Woerner authored
So far it is possible to pass list parameters with empty strings to the modules. The use of empty strings in list does not make a lot of sense, though. The simple solution is to add a check to module_params_get for empty strings in returned lists. The option allow_empty_string can be set to True to allow an empty string in the list with a list len of 1. The option defaults to False. It is needed for some parameters the modules, like for example userauthtype in the user module. It is using "" to reset to the default value. module_params_get_lowercase has been changed to use module_params_get to have one place to add the check. Due to an issue in Ansible it is possible to use the empty string "" for lists with choices, even if the empty list is not part of the choices. Ansible issue https://github.com/ansible/ansible/issues/77108
-