Skip to content
Snippets Groups Projects
Commit 4da89de1 authored by Rafael Guterres Jeffman's avatar Rafael Guterres Jeffman
Browse files

ipaconfig: Fix fail_json calls.

Ansible's fail_json() method required that the message paramater was
passed with a keyword parameter, rather than a positional one. Although
this seems to work with ansible-core 2.13+, it might not work with
previous versions of Ansible.

This patch fixes the behaviour for all supported Ansible versions.
parent 0ad76353
No related branches found
No related tags found
No related merge requests found
...@@ -533,13 +533,14 @@ def main(): ...@@ -533,13 +533,14 @@ def main():
required_sid = any([netbios_name, add_sids]) required_sid = any([netbios_name, add_sids])
if required_sid and not enable_sid: if required_sid and not enable_sid:
ansible_module.fail_json( ansible_module.fail_json(
"'enable-sid: yes' required for 'netbios_name' " msg="'enable-sid: yes' required for 'netbios_name' "
"and 'add-sids'." "and 'add-sids'."
) )
if enable_sid: if enable_sid:
if not has_enable_sid: if not has_enable_sid:
ansible_module.fail_json( ansible_module.fail_json(
"This version of IPA does not support 'enable-sid'.") msg="This version of IPA does not support enable-sid."
)
if ( if (
netbios_name netbios_name
and netbios_name == get_netbios_name(ansible_module) and netbios_name == get_netbios_name(ansible_module)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment