Merge pull request #400 from rjeffman/lint_fix_ansible_lint_issues

Make ansible-lint and yamllint use more strict rules.

Merge pull request #400 from rjeffman/lint_fix_ansible_lint_issues
b434c5f3 · Thomas Woerner · GitHub · 7b05c026 · a5310b0a · b434c5f3
Unverified Commit b434c5f3 authored Sep 30, 2021 by Thomas Woerner Committed by GitHub Sep 30, 2021
--- a/playbooks/role/role-member-user-absent.yml
+++ b/playbooks/role/role-member-user-absent.yml
@@ -5,7 +5,8 @@
  gather_facts: no

  tasks:
-  - iparole:
+  - name: Ensure role member 'user' is absent.
+    iparole:
      ipaadmin_password: SomeADMINpassword
      name: somerole
      user:

--- a/playbooks/role/role-member-user-present.yml
+++ b/playbooks/role/role-member-user-present.yml
@@ -5,7 +5,8 @@
  gather_facts: no

  tasks:
-  - iparole:
+  - name: Ensure role member 'user' is present.
+    iparole:
      ipaadmin_password: SomeADMINpassword
      name: somerole
      user:

--- a/playbooks/role/role-members-absent.yml
+++ b/playbooks/role/role-members-absent.yml
@@ -5,7 +5,8 @@
  gather_facts: no

  tasks:
-  - iparole:
+  - name: Ensure role members are absent.
+    iparole:
      ipaadmin_password: SomeADMINpassword
      name: somerole
      user:

--- a/playbooks/role/role-members-present.yml
+++ b/playbooks/role/role-members-present.yml
@@ -5,7 +5,8 @@
  gather_facts: no

  tasks:
-  - iparole:
+  - name: Ensure role members are present.
+    iparole:
      ipaadmin_password: SomeADMINpassword
      name: somerole
      user:
@@ -21,3 +22,4 @@
      - User Administrators
      service:
      - service01
+      action: member
--- a/playbooks/role/role-rename.yml
+++ b/playbooks/role/role-rename.yml
@@ -5,7 +5,8 @@
  gather_facts: no

  tasks:
-  - iparole:
+  - name: Rename role.
+    iparole:
      ipaadmin_password: SomeADMINpassword
      name: somerole
      rename: anotherrole
--- a/playbooks/service/service-host-is-absent.yml
+++ b/playbooks/service/service-host-is-absent.yml
@@ -5,8 +5,8 @@
  gather_facts: false

  tasks:
-  # Ensure management host is absent.
-  - ipaservice:
+  - name: Ensure management host is absent.
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
      host: "{{ groups.ipaserver[0] }}"

--- a/playbooks/service/service-host-is-present.yml
+++ b/playbooks/service/service-host-is-present.yml
@@ -5,8 +5,8 @@
  gather_facts: false

  tasks:
-  # Ensure management host is present.
-  - ipaservice:
+  - name: Ensure management host is present.
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
      host: "{{ groups.ipaserver[0] }}"

--- a/playbooks/service/service-is-absent.yml
+++ b/playbooks/service/service-is-absent.yml
@@ -5,8 +5,8 @@
  gather_facts: false

  tasks:
-  # Ensure service is absent
-  - ipaservice:
+  - name: Ensure service is absent
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
      state: absent
--- a/playbooks/service/service-is-disabled.yml
+++ b/playbooks/service/service-is-disabled.yml
@@ -5,8 +5,8 @@
  gather_facts: false

  tasks:
-  # Ensure service is disabled
-  - ipaservice:
+  - name: Ensure service is disabled
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
      state: disabled
--- a/playbooks/service/service-is-present-with-all-attributes.yml
+++ b/playbooks/service/service-is-present-with-all-attributes.yml
@@ -5,12 +5,25 @@
  gather_facts: false

  tasks:
-  # Ensure service is present
-  - ipaservice:
+  - name: Ensure service is present
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
      certificate:
-        - MIICBjCCAW8CFHnm32VcXaUDGfEGdDL/erPSijUAMA0GCSqGSIb3DQEBCwUAMEIxCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENpdHkxHDAaBgNVBAoME0RlZmF1bHQgQ29tcGFueSBMdGQwHhcNMjAwMTIzMDA1NjQ2WhcNMjEwMTIyMDA1NjQ2WjBCMQswCQYDVQQGEwJYWDEVMBMGA1UEBwwMRGVmYXVsdCBDaXR5MRwwGgYDVQQKDBNEZWZhdWx0IENvbXBhbnkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDYrdVmsr7iT3f67DM5bb1osSEe5/c91UUMEIcFq5wrgBhzVfs8iIMDVC1yiUGTsDLJNJc4nb1tUxeR9K5fh25E6n/eWDBP75NStotjAXRU4Ahi3FNRhWFOKesds5xNqgDk5/dY8UekJv2yUblQuZzeF8b2XFrmHuCaYuFctzPfWwIDAQABMA0GCSqGSIb3DQEBCwUAA4GBACF+5RS8Ce0HRixGPu4Xd51i+Kzblg++lx8fDJ8GW5G16/Z1AsB72Hc7etJL2PksHlue/xCq6SA9fIfHc4TBNCiWjPSP1NhHJeYyoPiSkcYsqXuxWyoyRLbnAhBVvhoiqZbUt3u3tGB0uMMA0yJvj07mP7Nea2KdBYVH8X1pM0V+
+        - >
+          MIICBjCCAW8CFHnm32VcXaUDGfEGdDL/erPSijUAMA0GCSqGSIb3DQ
+          EBCwUAMEIxCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENp
+          dHkxHDAaBgNVBAoME0RlZmF1bHQgQ29tcGFueSBMdGQwHhcNMjAwMT
+          IzMDA1NjQ2WhcNMjEwMTIyMDA1NjQ2WjBCMQswCQYDVQQGEwJYWDEV
+          MBMGA1UEBwwMRGVmYXVsdCBDaXR5MRwwGgYDVQQKDBNEZWZhdWx0IE
+          NvbXBhbnkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDY
+          rdVmsr7iT3f67DM5bb1osSEe5/c91UUMEIcFq5wrgBhzVfs8iIMDVC
+          1yiUGTsDLJNJc4nb1tUxeR9K5fh25E6n/eWDBP75NStotjAXRU4Ahi
+          3FNRhWFOKesds5xNqgDk5/dY8UekJv2yUblQuZzeF8b2XFrmHuCaYu
+          FctzPfWwIDAQABMA0GCSqGSIb3DQEBCwUAA4GBACF+5RS8Ce0HRixG
+          Pu4Xd51i+Kzblg++lx8fDJ8GW5G16/Z1AsB72Hc7etJL2PksHlue/x
+          Cq6SA9fIfHc4TBNCiWjPSP1NhHJeYyoPiSkcYsqXuxWyoyRLbnAhBV
+          vhoiqZbUt3u3tGB0uMMA0yJvj07mP7Nea2KdBYVH8X1pM0V+
      pac_type:
        - MS-PAC
        - PAD

--- a/playbooks/service/service-is-present-with-host-force.yml
+++ b/playbooks/service/service-is-present-with-host-force.yml
@@ -5,9 +5,8 @@
  gather_facts: false

  tasks:
-  # Ensure service is present
-  - ipaservice:
+  - name: Ensure service is present
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/ihavenodns.info
      force: yes
-      # state: absent
--- a/playbooks/service/service-is-present-without-host-object.yml
+++ b/playbooks/service/service-is-present-without-host-object.yml
@@ -5,8 +5,8 @@
  gather_facts: false

  tasks:
-  # Ensure service is present
-  - ipaservice:
+  - name: Ensure service is present
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.ansible.com
      skip_host_check: yes
--- a/playbooks/service/service-is-present.yml
+++ b/playbooks/service/service-is-present.yml
@@ -5,7 +5,7 @@
  gather_facts: false

  tasks:
-  # Ensure service is present
-  - ipaservice:
+  - name: Ensure service is present
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
--- a/playbooks/service/service-member-certificate-absent.yml
+++ b/playbooks/service/service-member-certificate-absent.yml
@@ -5,12 +5,24 @@
  gather_facts: false

  tasks:
-  # Ensure service certificate is absent
-  - ipaservice:
+  - name: Ensure service certificate is absent
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
-
      certificate:
-        - MIICBjCCAW8CFHnm32VcXaUDGfEGdDL/erPSijUAMA0GCSqGSIb3DQEBCwUAMEIxCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENpdHkxHDAaBgNVBAoME0RlZmF1bHQgQ29tcGFueSBMdGQwHhcNMjAwMTIzMDA1NjQ2WhcNMjEwMTIyMDA1NjQ2WjBCMQswCQYDVQQGEwJYWDEVMBMGA1UEBwwMRGVmYXVsdCBDaXR5MRwwGgYDVQQKDBNEZWZhdWx0IENvbXBhbnkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDYrdVmsr7iT3f67DM5bb1osSEe5/c91UUMEIcFq5wrgBhzVfs8iIMDVC1yiUGTsDLJNJc4nb1tUxeR9K5fh25E6n/eWDBP75NStotjAXRU4Ahi3FNRhWFOKesds5xNqgDk5/dY8UekJv2yUblQuZzeF8b2XFrmHuCaYuFctzPfWwIDAQABMA0GCSqGSIb3DQEBCwUAA4GBACF+5RS8Ce0HRixGPu4Xd51i+Kzblg++lx8fDJ8GW5G16/Z1AsB72Hc7etJL2PksHlue/xCq6SA9fIfHc4TBNCiWjPSP1NhHJeYyoPiSkcYsqXuxWyoyRLbnAhBVvhoiqZbUt3u3tGB0uMMA0yJvj07mP7Nea2KdBYVH8X1pM0V+
+        - >
+          MIICBjCCAW8CFHnm32VcXaUDGfEGdDL/erPSijUAMA0GCSqGSIb3DQ
+          EBCwUAMEIxCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENp
+          dHkxHDAaBgNVBAoME0RlZmF1bHQgQ29tcGFueSBMdGQwHhcNMjAwMT
+          IzMDA1NjQ2WhcNMjEwMTIyMDA1NjQ2WjBCMQswCQYDVQQGEwJYWDEV
+          MBMGA1UEBwwMRGVmYXVsdCBDaXR5MRwwGgYDVQQKDBNEZWZhdWx0IE
+          NvbXBhbnkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDY
+          rdVmsr7iT3f67DM5bb1osSEe5/c91UUMEIcFq5wrgBhzVfs8iIMDVC
+          1yiUGTsDLJNJc4nb1tUxeR9K5fh25E6n/eWDBP75NStotjAXRU4Ahi
+          3FNRhWFOKesds5xNqgDk5/dY8UekJv2yUblQuZzeF8b2XFrmHuCaYu
+          FctzPfWwIDAQABMA0GCSqGSIb3DQEBCwUAA4GBACF+5RS8Ce0HRixG
+          Pu4Xd51i+Kzblg++lx8fDJ8GW5G16/Z1AsB72Hc7etJL2PksHlue/x
+          Cq6SA9fIfHc4TBNCiWjPSP1NhHJeYyoPiSkcYsqXuxWyoyRLbnAhBV
+          vhoiqZbUt3u3tGB0uMMA0yJvj07mP7Nea2KdBYVH8X1pM0V+
      action: member
      state: absent
--- a/playbooks/service/service-member-certificate-present.yml
+++ b/playbooks/service/service-member-certificate-present.yml
@@ -5,11 +5,24 @@
  gather_facts: false

  tasks:
-  # Ensure service certificate is present
-  - ipaservice:
+  - name: Ensure service certificate is present
+    ipaservice:
      ipaadmin_password: SomeADMINpassword
      name: HTTP/www.example.com
      certificate:
-        - MIICBjCCAW8CFHnm32VcXaUDGfEGdDL/erPSijUAMA0GCSqGSIb3DQEBCwUAMEIxCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENpdHkxHDAaBgNVBAoME0RlZmF1bHQgQ29tcGFueSBMdGQwHhcNMjAwMTIzMDA1NjQ2WhcNMjEwMTIyMDA1NjQ2WjBCMQswCQYDVQQGEwJYWDEVMBMGA1UEBwwMRGVmYXVsdCBDaXR5MRwwGgYDVQQKDBNEZWZhdWx0IENvbXBhbnkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDYrdVmsr7iT3f67DM5bb1osSEe5/c91UUMEIcFq5wrgBhzVfs8iIMDVC1yiUGTsDLJNJc4nb1tUxeR9K5fh25E6n/eWDBP75NStotjAXRU4Ahi3FNRhWFOKesds5xNqgDk5/dY8UekJv2yUblQuZzeF8b2XFrmHuCaYuFctzPfWwIDAQABMA0GCSqGSIb3DQEBCwUAA4GBACF+5RS8Ce0HRixGPu4Xd51i+Kzblg++lx8fDJ8GW5G16/Z1AsB72Hc7etJL2PksHlue/xCq6SA9fIfHc4TBNCiWjPSP1NhHJeYyoPiSkcYsqXuxWyoyRLbnAhBVvhoiqZbUt3u3tGB0uMMA0yJvj07mP7Nea2KdBYVH8X1pM0V+
+        - >
+          MIICBjCCAW8CFHnm32VcXaUDGfEGdDL/erPSijUAMA0GCSqGSIb3DQ
+          EBCwUAMEIxCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENp
+          dHkxHDAaBgNVBAoME0RlZmF1bHQgQ29tcGFueSBMdGQwHhcNMjAwMT
+          IzMDA1NjQ2WhcNMjEwMTIyMDA1NjQ2WjBCMQswCQYDVQQGEwJYWDEV
+          MBMGA1UEBwwMRGVmYXVsdCBDaXR5MRwwGgYDVQQKDBNEZWZhdWx0IE
+          NvbXBhbnkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDY
+          rdVmsr7iT3f67DM5bb1osSEe5/c91UUMEIcFq5wrgBhzVfs8iIMDVC
+          1yiUGTsDLJNJc4nb1tUxeR9K5fh25E6n/eWDBP75NStotjAXRU4Ahi
+          3FNRhWFOKesds5xNqgDk5/dY8UekJv2yUblQuZzeF8b2XFrmHuCaYu
+          FctzPfWwIDAQABMA0GCSqGSIb3DQEBCwUAA4GBACF+5RS8Ce0HRixG
+          Pu4Xd51i+Kzblg++lx8fDJ8GW5G16/Z1AsB72Hc7etJL2PksHlue/x
+          Cq6SA9fIfHc4TBNCiWjPSP1NhHJeYyoPiSkcYsqXuxWyoyRLbnAhBV
+          vhoiqZbUt3u3tGB0uMMA0yJvj07mP7Nea2KdBYVH8X1pM0V+
      action: member
      state: present
--- a/playbooks/sudocmd/ensure-sudocmd-is-absent.yml
+++ b/playbooks/sudocmd/ensure-sudocmd-is-absent.yml
@@ -4,8 +4,8 @@
  become: true

  tasks:
-  # Ensure sudo command is absent
-  - ipasudocmd:
+  - name: Ensure sudo command is absent
+    ipasudocmd:
      ipaadmin_password: SomeADMINpassword
      name: /usr/bin/su
      state: absent
--- a/playbooks/sudocmd/ensure-sudocmd-is-present.yml
+++ b/playbooks/sudocmd/ensure-sudocmd-is-present.yml
@@ -4,8 +4,8 @@
  become: true

  tasks:
-  # Ensure sudo command is present
-  - ipasudocmd:
+  - name: Ensure sudo command is present
+    ipasudocmd:
      ipaadmin_password: SomeADMINpassword
      name: /usr/bin/su
      state: present
--- a/playbooks/sudocmdgroup/ensure-sudocmd-are-absent-in-sudocmdgroup.yml
+++ b/playbooks/sudocmdgroup/ensure-sudocmd-are-absent-in-sudocmdgroup.yml
@@ -4,8 +4,8 @@
  become: true

  tasks:
-  # Ensure sudocmds are absent in sudocmdgroup
-  - ipasudocmdgroup:
+  - name: Ensure sudocmds are absent in sudocmdgroup
+    ipasudocmdgroup:
      ipaadmin_password: SomeADMINpassword
      name: network
      sudocmd:

--- a/playbooks/sudocmdgroup/ensure-sudocmd-are-present-in-sudocmdgroup.yml
+++ b/playbooks/sudocmdgroup/ensure-sudocmd-are-present-in-sudocmdgroup.yml
@@ -4,16 +4,16 @@
  become: true

  tasks:
-  # Ensure sudo commands are present
-  - ipasudocmd:
+  - name: Ensure sudo commands are present
+    ipasudocmd:
      ipaadmin_password: SomeADMINpassword
      name:
      - /usr/sbin/ifconfig
      - /usr/sbin/iwlist
      state: present

-  # Ensure sudo commands are present in existing sudocmdgroup
-  - ipasudocmdgroup:
+  - name: Ensure sudocmdgroup is present with sudo commands.
+    ipasudocmdgroup:
     ipaadmin_password: SomeADMINpassword
     name: network
     sudocmd:

--- a/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml
+++ b/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml
@@ -4,8 +4,8 @@
  become: true

  tasks:
-  # Ensure sudocmdgroup is absent
-  - ipasudocmdgroup:
+  - name: Ensure sudocmdgroup is absent
+    ipasudocmdgroup:
      ipaadmin_password: pass1234
      name: network
      state: absent