Skip to content
  1. Sep 15, 2021
  2. Sep 14, 2021
  3. Sep 13, 2021
  4. Sep 09, 2021
  5. Sep 08, 2021
  6. Sep 07, 2021
    • Thomas Woerner's avatar
      hbacrule: Use execute_ipa_commands · 928deb21
      Thomas Woerner authored
      execute_ipa_commands replces the check mode exit, the loop over the
      generated commands and also in the member failure handling for modules
      with member support.
      928deb21
    • Thomas Woerner's avatar
      group: Use execute_ipa_commands · 19073730
      Thomas Woerner authored
      execute_ipa_commands replces the check mode exit, the loop over the
      generated commands and also in the member failure handling for modules
      with member support.
      19073730
    • Thomas Woerner's avatar
      delegation: Use execute_ipa_commands · 95ffd2c5
      Thomas Woerner authored
      execute_ipa_commands replces the check mode exit, the loop over the
      generated commands and also in the member failure handling for modules
      with member support.
      95ffd2c5
    • Thomas Woerner's avatar
      automember: Use execute_ipa_commands · e6f0eb23
      Thomas Woerner authored
      execute_ipa_commands replces the check mode exit, the loop over the
      generated commands and also in the member failure handling for modules
      with member support.
      e6f0eb23
    • Thomas Woerner's avatar
      IPAAnsibleModule: New staticethod member_error_handler · 917b3b62
      Thomas Woerner authored
      The staticmethod member_error_handler is handing the default member
      related failures that can occur for modules with member support.
      This can simply be enabled with fail_on_member_errors=True for
      execute_ipa_commands.
      
      An exception handler is also now usable with execute_ipa_commands. In
      addition to the the exception it is also getting the same user defined
      arguments that the result_handler is getting.
      
      handle_result has been renamed in result_handler and handle_result_user_args
      has been renamed to handlers_user_args.
      
      Additionally the errors list does not need to be defined in the module.
      The method execute_ipa_commands is doing this internally and is also
      adding error: error to handlers_user_args if the handler is having errors
      in the argspec and errors is not yet set in handlers_user_args.
      
      Tests have been added to make sure that no user args for the handler
      have been set without an own result or exception handler. Also the use of
      fail_on_member_errors together with a result_andler is leading to an
      error.
      917b3b62
  7. Sep 06, 2021
  8. Sep 05, 2021
  9. Sep 03, 2021
  10. Sep 02, 2021
    • Thomas Woerner's avatar
      config: Use IPAAnsibleModule class · ed3dd3ea
      Thomas Woerner authored
      ipaadmin_variables are handled by IPAAnsibleModule,
      ansible_module.params_get is used to get the parameters and
      ansible_module.ipa_connect is used to simplify the module.
      ed3dd3ea
    • Thomas Woerner's avatar
      ansible_freeipa_module: Cleanup of unused functions and attributes · 3e98ed54
      Thomas Woerner authored
      Moved ipamodule_base_spec into IPAAnsibleModule.
      This simplifies to add addtitional base vars to derived classes without
      the need to dusplicae the code to extend argument_spec.
      
      Removed execute_api_command.
      This is not used anymore.
      
      Removed get_ipamodule_base_vars.
      This is not used anymore.
      
      Removed self.ipaadmin_* and self.ccache_* from IPAAnsibleModule.__init__
      These are not used and therefore can be removed.
      3e98ed54
    • Thomas Woerner's avatar
      ansible_freeipa_module: New execute_ipa_commands in IPAAnsibleModule · 55341a03
      Thomas Woerner authored
      execute_ipa_commands executes IPA API commands from the given command
      list. With the handle_result and handle_result_user_args it is possible
      to have a handling of the result return by the ipa commands for example
      to return passwords.
      
      Parameters
      
          commands: list of string tuple
              The list of commands in the form (name, command and args)
              For commands that do not require a 'name', None needs be
              used.
          handle_result: function
              The user function to handle results of the single commands
          handle_result_user_args: dict (user args mapping)
              The user args to pass to handle_result function
      
      Example (ipauser module)
      
          def handle_result(result, command, name, args, exit_args):
              if "random" in args and command in ["user_add", "user_mod"] \
                 and "randompassword" in result["result"]:
                  exit_args.setdefault(name, {})["randompassword"] = \
                      result["result"]["randompassword"]
      
          exit_args = {}
          changed = module.execute_ipa_commands(commands, handle_result,
                                                exit_args=exit_args)
      
          if len(names) == 1:
              ansible_module.exit_json(changed=changed,
                                       user=exit_args[names[0]])
          else:
              ansible_module.exit_json(changed=changed, user=exit_args)
      55341a03
    • Rafael Guterres Jeffman's avatar
      automountlocation: Use IPAAnsibleModule class · 706e1f5b
      Rafael Guterres Jeffman authored
      Use IPAAnsibleModule methods and ipamodule_base_docs ducument fragment.
      706e1f5b
    • Rafael Guterres Jeffman's avatar
      dnszone: Use IPAAnsibleModule class. · 21a48d59
      Rafael Guterres Jeffman authored
      Use IPAAnsibleModule methods and ipamodule_base_docs ducument fragment.
      21a48d59