- Apr 26, 2022
-
-
Thomas Woerner authored
DNS forward policy: ensure consistency between module parameters.
-
Thomas Woerner authored
utils/new_module templates: Add missing password to example playbooks.
-
Thomas Woerner authored
Update module templates to current practices.
-
Thomas Woerner authored
ansible-lint: Identify env_*.yml and tasks_*.yml as task files.
-
- Apr 25, 2022
-
-
Rafael Guterres Jeffman authored
Failing to identify task files included by playbooks raised false positives when runnnig ansible lint. This change force ansible-lint to correctly identify YAML files named "env_*.yml" or "tasks_*.yml" as task files that are imported by other playbooks, and treat them accordingly.
-
- Apr 12, 2022
-
-
Rafael Guterres Jeffman authored
Modules ipadnsconfig and ipadnsforwardzone allow the setting of forward policy for zone forwarders, but the parameter names differ between the modules. This patch ensures that the same parameter names can be used in each module. To keep backwar compatibility in both modules, both `forward_policy` and `forwardpolicy` are now supported.
-
Rafael Guterres Jeffman authored
Add missing ipaadmin_password to example playbooks so new modules have all necessary fields set on basic files.
-
- Apr 07, 2022
-
-
Rafael Guterres Jeffman authored
Update README-group.md
-
- Apr 06, 2022
-
-
vjs2174 authored
Fixed issue #790 changed line 103 to be more accurate.
-
- Apr 05, 2022
-
-
Thomas Woerner authored
Ensure example playbooks have ipaadmin_password and it is the standard one.
-
Thomas Woerner authored
Update pylint to version 2.12.2
-
- Mar 30, 2022
-
-
Rafael Guterres Jeffman authored
Some example playbooks do not had the parameter `ipaadmin_password` set, and some had a different value than the standard value "SomeADMINpassword". This patch fixes this difference in all example playbooks.
-
Rafael Guterres Jeffman authored
-
- Mar 22, 2022
-
-
Rafael Guterres Jeffman authored
Update pylint version to the latest supported by Fedora 36.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
Newer versions of pylint warns about not using f-strings, but those are not supported in Python 2, which ansible-freeipa still need to support.
-
- Mar 03, 2022
-
-
Varun Mylaraiah authored
module_params_get*: Fail on empty string in string list parameters
-
- Feb 28, 2022
-
-
Rafael Guterres Jeffman authored
automember: Remove debug output
-
Thomas Woerner authored
The warn debug line was added with "Add automember default group handling" d2648b14
-
Thomas Woerner authored
The parameters user_auth_type, pac_type and configstring are allowing to use "" to reset to the default value or for configstring to set an empty list. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. Additionally empty pac_type, user_auth_type and domain_resolution_order have been added to exit_args as if they have not been set.
-
- Feb 25, 2022
-
-
Thomas Woerner authored
The parameter auth_ind is allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working.
-
Thomas Woerner authored
The parameters auth_ind and pac_type are allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. An idempotency issue with pac_type has been found with the test and fixed additionally.
-
- Feb 24, 2022
-
-
Thomas Woerner authored
The parameters userauthtype and sshpubkey allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. An idempotency issue with sshpubkey has been found with the test and fixed additionally.
-
Thomas Woerner authored
So far it is possible to pass list parameters with empty strings to the modules. The use of empty strings in list does not make a lot of sense, though. The simple solution is to add a check to module_params_get for empty strings in returned lists. The option allow_empty_string can be set to True to allow an empty string in the list with a list len of 1. The option defaults to False. It is needed for some parameters the modules, like for example userauthtype in the user module. It is using "" to reset to the default value. module_params_get_lowercase has been changed to use module_params_get to have one place to add the check. Due to an issue in Ansible it is possible to use the empty string "" for lists with choices, even if the empty list is not part of the choices. Ansible issue https://github.com/ansible/ansible/issues/77108
-
- Feb 21, 2022
-
-
Thomas Woerner authored
hbacrule: Allow clearing members with empty lists.
-
- Feb 17, 2022
-
-
Rafael Guterres Jeffman authored
This patch add the lines necessary to allow the use of the attribute `delete_continue`, as it is a commom attribute, and if newer commom attributes are added to IPAAnsibleModule in the future, the usage will be similar.
-
Rafael Guterres Jeffman authored
Some modules should be compared in a case insensitive manner, and this patch adds an example of a call to IPAAnsibleModule.params_get_lowercase and a note on its usage.
-
Rafael Guterres Jeffman authored
This patch refactors the module template for modules with member management, in a way that the addition of member management command logic is not duplicated in different states or actions. This idiom has been applied recently along with other fixes to modules with idempotence issues reducing the modules code size and centering code logic in specific blocks.
-
Thomas Woerner authored
IPAAnsibleModule: Provide base configuration for delete_continue.
-
Rafael Guterres Jeffman authored
Allows the creation of IPAAnsibleModule objects with specific `ipa_arguments` which are defined in a dictionary of argumets in the base class. Every module using `delete_continue` should provide the proper behavior and the module must be instantiated with: ansible_module = IPAAnsibleModule( ..., ipa_arguments=["delete_continue"] ) The plugin documentation must be extended with 'ipamodule_arguments.delete_continue'.
-
Thomas Woerner authored
upstream ci: Fix scenario for Centos 8 Stream with Ansible 2.11.
-
- Feb 16, 2022
-
-
Thomas Woerner authored
upstream ci: Rename CentOS 9 pipelines jobs to c9s.
-
Rafael Guterres Jeffman authored
Changed scenario from old CentOS 8 (centos-8) to current Centos 8 Stream (c8s).
-
Rafael Guterres Jeffman authored
The correct name for upcoming release of CentOS is CentOS 9 Stream, usually abbreviated to 'c9s'. As we need to differentiate from the stream and the standard versions, this patch modifies the Azure piipelines to use 'c9s' instead of 'CentOS 9'.
-
Thomas Woerner authored
ansible-lint: Remove warning on 'ignore_errors'.
-
Thomas Woerner authored
upstream CI: Fix container builds in face of Ansible and CentOS changes.
-
Thomas Woerner authored
upstream CI: Enable CentOS 8 Stream for PR and nightly tests.
-
Thomas Woerner authored
upstream ci: enable ansible-core 2.12 for CentOS 9 Stream.
-
- Feb 15, 2022
-
-
Rafael Guterres Jeffman authored
The test for dnsrecord creates a DNSSEC zone, and was forcing the task to ignore errors using `ignore_errors: true`. The test environment should be clean at that point, and without the zone, tests would fail, so there is no need to keep the attribute set. If the task fails, it should be fixed.
-
Rafael Guterres Jeffman authored
molecule: Disable prerun for normal tests
-