- Sep 30, 2022
-
-
Thomas Woerner authored
ansible-test with ansible-2.14 is adding a lot of new tests to ensure that the documentation section and the agument spec is complete. Needed changes: DOCUMENTATION section - `type: str` needs to be set for string parameters - `type: list` needs to be set for list parameters - `elements: str` needs to be given for list of string parameters - `required` tags need to be fixed according to the `argument_spec` - all parameters need to be defined - `author` needs to be given with the github user also: `Name (@user)` argument_spec - `elements="str"` needs to be added to all list of string parameters The `copyright` date is extended with `-2022`.
-
- Sep 27, 2022
-
-
Rafael Guterres Jeffman authored
Fix plugins for ansible fake execution test
-
Rafael Guterres Jeffman authored
ipabackup_get_backup_dir: Fix for ansible-test fake execution test
-
Rafael Guterres Jeffman authored
ipasmartcard_client_get_vars: Fix for ansible-test fake execution test
-
Rafael Guterres Jeffman authored
ipasmartcard_server_get_vars: Fix for ansible-test fake execution test
-
Thomas Woerner authored
ERROR: Found 2 pylint issue(s) which need to be resolved: ERROR: tests/sanity/ignore-2.12.txt:3:1: ansible-test: Ignoring 'ansible-bad-import-from' on 'plugins/module_utils/ansible_freeipa_module.py' is unnecessary ERROR: tests/sanity/ignore-2.12.txt:5:1: ansible-test: Ignoring 'ansible-format-automatic-specification' on 'plugins/module_utils/ansible_freeipa_module.py' is unnecessary
-
Thomas Woerner authored
ansible_freeipa_module is providing netaddr and also DNSName, therefore it is not needed to have own imports in the module. These own imports would need an addional try exception clause to be able to pass the ansible-test fake execution test.
-
Thomas Woerner authored
All imports that are only available after installing IPA need to be in a try exception clause to be able to pass the fake execution test. If the imports can not be done, all used and needed attributes are defined with the value None, MODULE_IMPORT_ERROR is set to the import error and fail_json is called.
-
Thomas Woerner authored
All imports that are only available after installing IPA need to be in a try exception clause to be able to pass the fake execution test. The old workaround "if 'ansible.executor' in sys.modules:" is not working with this test anymore. If the imports can not be done, all used and needed attributes are defines with the value None. A check has been added to IPAAnsibleModule.__init__ to make sure that it fails if the imports have not been done successfully.
-
Thomas Woerner authored
All imports that are only available after installing IPA need to be in a try exception clause to be able to pass the fake execution test. If the imports can not be done, all used and needed attributes are defined with the value None, MODULE_IMPORT_ERROR is set to the import error and fail_json is called.
-
Thomas Woerner authored
All imports that are only available after installing IPA need to be in a try exception clause to be able to pass the fake execution test. If the imports can not be done, all used and needed attributes are defined with the value None, MODULE_IMPORT_ERROR is set to the import error and fail_json is called.
-
Thomas Woerner authored
All imports that are only available after installing IPA need to be in a try exception clause to be able to pass the fake execution test. If the imports can not be done, all used and needed attributes are defined with the value None, MODULE_IMPORT_ERROR is set to the import error and fail_json is called.
-
Rafael Guterres Jeffman authored
Re-enable dnsforwardzone tests
-
- Sep 16, 2022
-
-
Rafael Guterres Jeffman authored
ansible_freeipa_module: Remove deprecated FreeIPABaseModule
-
Rafael Guterres Jeffman authored
As the latest versions of FreeIPA contain fixes to set the port on DNS forwarders, this patch re-enables the upstream tests.
-
Rafael Guterres Jeffman authored
Update instuctions on Azure template varible files to reflect the current test configuration behavior.
-
Thomas Woerner authored
ansible-deprecated-no-collection-name is not needed anymore for plugins/module_utils/ansible_freeipa_module.py with the removal of FreeIPABaseModule class.
-
Thomas Woerner authored
The FreeIPABaseModule class has been maked deprecated with ansible-freeipa version 1.5.0. It is not used in the code any more therefore it is time to finally remove it.
-
- Sep 09, 2022
-
-
Rafael Guterres Jeffman authored
utils/ansible-freeipa.spec.in: Sync with Fedora rawhide spec file
-
Thomas Woerner authored
ipaconfig: Fix example playbook titles.
-
Thomas Woerner authored
ipaconfig: Add support for SID related attributes.
-
Rafael Guterres Jeffman authored
Since FreeIPA 4.9.8 the 'config_mod' command has parameters to enable and configure SIDs, and set the Netbios name. This patch adds the following parameters to ipaconfig plugin: enable_sids: New users and groups automatically get a SID assigned add_sids: Add SIDs for existing users and groups netbios_name: NetBIOS name of the IPA domain Both add_sids and netbios_name requires 'enable_sid: yes'. 'enable_sid' and 'netbios_name' are returned when querying IPA configuration. 'add_sids' always generate SIDs for users and groups, so, muiltiple executions of the playbook with 'add_sids: yes' will return 'changed', even if users and groups SIDs are not modified. A new test playbook is available: tests/config/test_config_sid.yml New examples playbooks are available: playbooks/config/change-ipa-domain-netbios-name.yml playbooks/config/generate-users-groups-sids.yml Fixes: #781 Related: https://bugzilla.redhat.com/show_bug.cgi?id=2069174 Related: https://bugzilla.redhat.com/show_bug.cgi?id=2069184
-
Rafael Guterres Jeffman authored
-
- Sep 08, 2022
-
-
Thomas Woerner authored
ipabackup: Fix order of ipabackup_name parameter evaluation.
-
Thomas Woerner authored
upstream CI: Force retrieval of ansible-freeipa master.
-
Rafael Guterres Jeffman authored
This patch forces the addition of a remote repository pointing to the main ansible-freeipa repo, and fetch its contents before confaring the modified files. The remote repository is removed after the modified file list is generated.
-
Rafael Guterres Jeffman authored
This patch forces the addition of a remote repository pointing to the main ansible-freeipa repo, and fetch its contents before confaring the modified files. The remote repository is removed after the modified file list is generated.
-
Rafael Guterres Jeffman authored
When performing a backup with 'state:present', if 'ipabackup_name' is provided, the backup will be performed, but the role with return an error since 'ipabackup_name' should not be set for this state. This patch moves the parameter evaluation to be performed before the actual backup is performed, so that the backup is not performed and an error is reported.
-
Thomas Woerner authored
The spec file was updated and was lacking several updates.
-
- Sep 07, 2022
-
-
Thomas Woerner authored
ipabackup: Add playbook tests for ipabackup.
-
- Sep 06, 2022
-
-
Thomas Woerner authored
upstream CI: Ensure 'master' branch is available for set_test_modules
-
Rafael Guterres Jeffman authored
If the repository is setup in a way that master branch is not available for comparing the current HEAD against it, the comparison will fail and not module/role will be scheduled for testing. This patch forces fetching 'master' from ansible-freeipa repository, allowing the comparison to be performed.
-
Thomas Woerner authored
upstream CI: run PR tests only for affected plugins
-
Rafael Guterres Jeffman authored
A new test playbook for ipabackup role can be found at: tests/role_backup/test_backup.yml The test is not yet complete, as 'state: restored' is not tested.
-
- Sep 05, 2022
-
-
Rafael Guterres Jeffman authored
ipaserver/ipareplica: Add isatty method to AnsibleModuleLog
-
Thomas Woerner authored
In some cases ipa code is using sys.stdout.isatty. As stdout is mapped to AnsibleModuleLog this call will lead in a traceback as it was not defined. The staticmethod isatty has been added to AnsibleModuleLog in ipaserver role module_utils/ansible_ipa_server.py and in ipareplica role module_utils/ansible_ipa_repica.py. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2120415 ansible-freeipa Replica Install Setup DNS fails Fixes: #251 - 'AnsibleModuleLog' object has no attribute 'isatty' Fixes: #117 - 'AnsibleModuleLog' object has no attribute 'isatty'
-
- Sep 03, 2022
-
-
Rafael Guterres Jeffman authored
The current workflow for bug fixing or new enhancements in ansible-freeipa includes running Ansible playbooks tests for all the available plugins for every pull request, even for contained modifications. This patch creates a new workflow for pull requests where only the affected plugins are tested in the PR. Changes that might affect other parts of the code will trigger tests for the parts affected. A utility script, utils/filter_tests, is used to set the variables IPA_ENABLED_MODULES and IPA_ENABLED_TESTS before executing the tests, effectively limiting which tests are executed. The script uses the python plugin 'utils/filter_plugins.py' which lists all test modules that should be executed for a list of modified source files. Tests are selected for execution based on the plugin name. For example, a change to 'plugins/modules/ipalocation.py' would trigger all playbook tests under 'tests/location'. If a test playbook is modified, it is scheduled to be ...
-
- Aug 31, 2022
-
-
Rafael Guterres Jeffman authored
This patch adds support for IPA_ENABLED_* and IPA_DISABLED_* environment variables as existing global configuration for the tests.
-
Rafael Guterres Jeffman authored
The plugin pytest-split-tests is used to split the tests in several groups so that the tests can be executed in parallel is upstream CI. The issue is thet pytest-split-tests last release was more that a year ago, upstream developers have not been responsive, and there is a bug when the number of tests to be executed by a group is zero. The patch to fix this issue has been open for a year. This patch deprecates the use of pytest-split-tests, changing the plugin used to split the tests to pytest-split, which is actively mainatined.
-
Thomas Woerner authored
Run tests locally with upstream CI images.
-