- Aug 24, 2022
-
-
Rafael Guterres Jeffman authored
Sometimes, mostly due do differences in package versions, there are some tests that fail on a single distribution which cannot be fixed by ansible-freeipa, requiring that the offending package is fixed. To keep tests running succesfully we have options to disable the failing tests, but this changes are globally applied, meaning that, by disabling a test, it is disable in all tested distributions. This patch allows tests to be enabled or disabled for a specific distribution, by setting the configuration on the 'variable' template for the specific testing scenario.
-
Thomas Woerner authored
ipasudorule: Fix usage of 'action' and 'state' in examples.
-
- Aug 23, 2022
-
-
Rafael Guterres Jeffman authored
Some examples in ipasudorule were using `action: enabled` when it should've been `state: enabled`. The examples were fixed.
-
- Aug 16, 2022
-
-
Varun Mylaraiah authored
ipavault: Fix missing whitespace after keyword issue
-
Varun Mylaraiah authored
ipareplica: ipareplica_setup_adtrust fails while updating ipaNTFlatName
-
Thomas Woerner authored
flake8 reports an issue in ipavault: plugins/modules/ipavault.py:528:20: E275 missing whitespace after keyword The missing whitespace has been added: "and not(" -> "and not ("
-
- Aug 15, 2022
-
-
Thomas Woerner authored
The internal parameter sid_generation_always is generated in ipareplica_test to enable SID generation if ipareplica_setup_adtrust is not enabled. This parameter was not used for ipareplica_prepare though, therefore adtrust.install_check was not executed and did not set the attribute adtrust.netbios_name. As a result adtrust.netbios_name was None and the try to use this as the new NetBIOS domain name failed with an INVALID_SYNTAX error in adtrustinstance while executing ipareplica_setup_adtrust. This issue only occurs if SIDs are not enabled in the domain yet for example with an old deployment.
-
- Jul 28, 2022
-
-
Thomas Woerner authored
ipaclient: Removed invalid call `logger.info()`
-
Varun Mylaraiah authored
ipaserver/ipareplica: Always generate SIDs
-
- Jul 27, 2022
-
-
jpclipffel authored
- Call was responsible for a `TypeError` exception - Call was not useful (already followed by a proper `logger.warning` call) Should fix issue #865: https://github.com/freeipa/ansible-freeipa/issues/865
-
Thomas Woerner authored
The SID is always generated in the command line installers in newer IPA versions. This also needs to be done in the ipaserver and ipareplica roles. For the IPA versions that are supporting this, the adtrust setup is always executed to generated the SIDs, but only configures AD trust if ipaserver_setup_adtrust or ipareplica_setup_adtrust is also enabled. A check has been added to ipaserver_test and ipareplica_test to only enable the SID generation for the IPA versions supporting this. This is related to https://pagure.io/freeipa/8995 Fixes: - https://bugzilla.redhat.com/show_bug.cgi?id=2110478 - https://bugzilla.redhat.com/show_bug.cgi?id=2110491
-
- Jul 25, 2022
-
-
Varun Mylaraiah authored
ipaserver,ipareplica: Fix Random Serial Numbers always enabled
-
Thomas Woerner authored
ipadnsconfig: Fix boolean values comparison
-
Thomas Woerner authored
The option _random_serial_numbers was using with the wrong type in ipaserver_setup_ca.py and ipareplica_setup_ca.py. Therefore RSN was always enabled. Fixes: - https://bugzilla.redhat.com/show_bug.cgi?id=2110523 - https://bugzilla.redhat.com/show_bug.cgi?id=2110526
-
- Jul 21, 2022
-
-
Rafael Guterres Jeffman authored
This patch disables only the tests that are failing due to python-dns issue in FreeIPA, allowing other tests in the test suite to be executed.
-
Rafael Guterres Jeffman authored
Due to an issue with python-dns, FreeIPA is raising an expection when setting a DNS forwarder with a custom port. Separating the test for ipadnsconfig that use forwarders with custom allows the other tests to be correctly executed.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
IPA 4.9.10+ handles LDAP boolean values correctly, and the comparison should be executed with the values itself, instead of a string representation.
-
- Jul 08, 2022
-
-
Thomas Woerner authored
upstream CI: enable tests on Fedora Rawide.
-
Thomas Woerner authored
sanity.sh: Allow use of podman instead of docker
-
Rafael Guterres Jeffman authored
ansible_freeipa_module: Use ipaplatform.tasks.parse_ipa_version
-
Rafael Guterres Jeffman authored
When running tests/sanity/sanity.sh locally, podman might be available instead of Docker. Due to current configuration, only Docker is used by sanity.sh. This patch searches for the availability of docker, which is kept as the default container engine to use, and use podman only if docker is not found. This change also allows the execution of the script from a directory other than the repository root.
-
Thomas Woerner authored
api_check_ipa_version was using packaging.version. IPA is using pkg_resources.parse_version in ipaplatform.tasks.parse_ipa_version. With this change tasks.parse_ipa_version from ipaplatform is used to have exactly the same version comparison that also IPA has. Additionally tasks is added to __all__.
-
- Jul 07, 2022
-
-
Rafael Guterres Jeffman authored
This patch enable upstream CI to build a testing Fedora Rawhide container and enables its use in nightly and weekly test runs.
-
- Jul 06, 2022
-
-
Thomas Woerner authored
Fix handling of boolean values for FreeIPA 4.9.10+
-
Rafael Guterres Jeffman authored
Provide own getargspec for roles and modules with Python 3.11
-
Rafael Guterres Jeffman authored
Evaluating boolean values output by FreeIPA must use regular expressions to handle both "TRUE/FALSE" and "True/False".
-
Rafael Guterres Jeffman authored
Checking if some output is present or absent from standard streams was done by simple string searching. Due to recent changes in FreeIPA, this search is not effective due to capitalization differences in boolean values output. Changing the string searching to regular expression searches fixes this behavior for current and previous versions of FreeIPA. This patch also adds more information on the assert tests in case of an error, so that it is easier to understand why the test failed.
-
Rafael Guterres Jeffman authored
The fallback function used to compare IPA versions was spliting the version string into a tuple of strings, and the comparison of the tuple would fail if comparing a field with one digit aginst a two-digit one, for example, '8' with '10', as the string comparison would put '10' before the '8'. This patch forces the version fields to be converted to integers, so a numerical comparison will be performed. If a version string field cannot be converted to a number, than the string comparison will still be used.
-
Rafael Guterres Jeffman authored
FreeIPA 4.9.10+ and 4.10 use proper mapping for boolean values, and only searching for "TRUE" does not work anymore. This patch fix ipadnszone plugin and IPAParamMapping class handling of boolean values.
-
Rafael Guterres Jeffman authored
tests/server/test_server.yml: Fix generation of ipaserver_domain
-
Rafael Guterres Jeffman authored
ipaserver,ipareplica: Add random_serial_numbers to options
-
Thomas Woerner authored
The generation of ipaserver_domain has issues: At first ansible_facts['hostname'] instead of ansible_facts['fqdn'] is used and second the first entry after the split operation is used and third the final join is missing.
-
Thomas Woerner authored
Python 3.11 dropped compat inspect.getargspec. As the roles and modules need to support Python2 and Python3, the code for getargspec has been copied from Python 3.10 and is added as a fallback as soon as getargspec can not be imported from inspect. The copied getargspec is using getfullargspec internally. Fixes: #855 (Python's inspect.getargspec was removed in version 3.11)
-
Thomas Woerner authored
With the support for Random Serial Numbers v3 in FreeIPA 4.10, the attribute random_serial_numbers has been added to the installer options. options._random_serial_numbers is generated by ca.install_check and later used by ca.install in the _setup_ca module. ca.install_check is using options.random_serial_numbers and generating options._random_serial_numbers which is later used by ca.install in ca.install the _setup_ca module. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2103928 https://bugzilla.redhat.com/show_bug.cgi?id=2103924
-
- Jul 05, 2022
-
-
Rafael Guterres Jeffman authored
ipaserver: Use jinja for list concatenation
-
Thomas Woerner authored
With ansible-2.13 it is required to use jinja for list concatenation. list: "[] + ['a'] + ['b']" needs to become list: "{{ [] + ['a'] + ['b'] }}" copy_external_cert.yml needed to be changed.
-
- Jun 24, 2022
-
-
Thomas Woerner authored
upstream CI: Update nightly Ansible versions.
-
- Jun 23, 2022
-
-
Rafael Guterres Jeffman authored
As the current latest upstream version of ansible-core is 2.13.0, to test against ansible-core 2.12 series we need to pin the version used on the test. This patch enables the already defined tests for ansible-core 2.12 that were available but commented out.
-
Rafael Guterres Jeffman authored
Ansible 2.9 is EOL, and we should only test with supported upstream versions of Ansible. This patch removes tests against Ansible 2.9.
-