- May 05, 2023
-
-
Thomas Woerner authored
The old ignore file ignore-2.12.txt is not needed and used anymore. The new files ignore-2.13.txt and ignore-2.14.txt are empty after ansible-lint made nearly all ignores disallowed. All the newly disallowed ignores need to be fixed. See https://github.com/ansible/ansible-lint/pull/3102
-
Rafael Guterres Jeffman authored
Pin requests to < 2.29 temporarily
-
Thomas Woerner authored
Due to https://github.com/docker/docker-py/issues/3113 requests need to be pinned below 2.29 as a temporary solution.
-
- Apr 28, 2023
-
-
Rafael Guterres Jeffman authored
tests/azure: Install molecule-plguins to get docker driver
-
- Apr 27, 2023
-
-
Thomas Woerner authored
The docker driver is not part of molecule 5.0.0 anymore. molecule-plugins need to be installed to get the driver.
-
- Apr 20, 2023
-
-
Rafael Guterres Jeffman authored
Fixes and enhancements for utils/new_module and templates
-
Rafael Guterres Jeffman authored
Create action group in collection for use with module_defaults
-
Thomas Woerner authored
The usage of module_defaults allows to reduce the size of the tests and to have the needed information in the tasks only. The default values for the parameters are automatically passed to the module by Ansible. It is not possible to use a module group for module_defaults as this could only be done with Ansible Collections. The tests are also used upstream and downstream without a collection. Without groups of a collection it is needed to add the defaults for all modules separately. Simple example: module_defaults: ipahost: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" Several module example using YAML anchors and aliases: module_defaults: ipahost: &ipa_module_defaults ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" ipauser: *ipa_module_defaults ipagroup: *ipa_module_defaults
-
Thomas Woerner authored
The documentation for "become" and "gather_facts" has been updated to make sure that these parameters are enabled only in new tests if it is really needed.
-
Thomas Woerner authored
The values "yes" and "no" will not be valid in the future for bool parameters. Therefore "yes" and "no" have been replaced by "true" and "false".
-
Thomas Woerner authored
The module action group <collection-prefix>.modules is created automatically while building the galaxy release. The action group can be used for module_defaults in this way: module_defauls: group/<collection-prefix>.modules: ipaadmin_password: SomeADMINpassword Example: module_defaults: group/freeipa.ansible_freeipa.modules: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" collections: - freeipa.ansible_freeipa
-
Thomas Woerner authored
The section module_defaults was not handled by utils/galaxyfy.py, also there was no verification that only roles and modules provided by ansible-freeipa are matched for prepending the collection prefix.
-
- Apr 18, 2023
-
-
Thomas Woerner authored
The list of modules and roles is needed in several scripts now, therefore it makes sense to have one place for this. Here are the current variables: BASE_DIR: Base directory of the repo ROLES: List of roles in the roles folder MANAGEMENT_MODULES: List of management modules in the plugins/modules folder ROLES_MODULES: List of modules in the roles/*/library folders ALL_MODULES: List of all modules, the management and the roles modules All lists are sorted.
-
- Apr 14, 2023
-
-
Thomas Woerner authored
The parameter argument spec of name was missing the closing bracket. The bracket has been added.
-
Rafael Guterres Jeffman authored
When testing the number parameters for new_module, the `github_user` was not being taken into account.
-
Thomas Woerner authored
new_module was always failing with "github_user is not valid". The wrong variable was checked: $githubuser instead of $github_user.
-
- Apr 05, 2023
-
-
Varun Mylaraiah authored
ipaserver: Do not enable random serial numbers by default
-
Thomas Woerner authored
ipaserver_random_serial_numbers was enabled by default in roles/ipaserver/defaults/main.yml. This should not be the default and also resulted in issues in all IPA versions that do not support RSN. The parameter now defaults to false.
-
Rafael Guterres Jeffman authored
ipagroup: Fix ensuring external group group members (without trust-ad)
-
- Apr 04, 2023
-
-
Thomas Woerner authored
roles/ipaserver: Allow deployments with random serial numbers
-
Thomas Woerner authored
Update `EXAMPLE` sections for multiuser and multihost handling.
-
Rafael Guterres Jeffman authored
Since FreeIPA version 4.10 it is possible to deploy servers that use Random Serial Number v3 support for certificates. This patch exposes the 'random_serial_numbers' parameter, as 'ipaserver_random_serial_numbers', allowing a user to have random serial numbers enabled for the domain. The use of random serial numbers is allowed on new installations only.
-
Thomas Woerner authored
[RFE] Allow multiple groups creation
-
Thomas Woerner authored
Ensuring (adding) several groups with mixed types external, nonposix and posix require to have a fix in IPA: FreeIPA issue: https://pagure.io/freeipa/issue/9349 FreeIPA fix: https://github.com/freeipa/freeipa/pull/6741 The simple solution is to switch to client context for ensuring several groups simply if the user was not explicitly asking for the server context no matter if mixed types are used.
-
Denis Karpelevich authored
Adding an option `groups` to create multiple groups in one operation. Adding tests (present/absent/external/nonposix) with server and client context. Simple example of `groups` option: ``` tasks: - name: Ensure 2 groups are present ipagroup: ipaadmin_password: SomeADMINpassword groups: - name: group1 - name: group2 ``` Signed-off-by: Denis Karpelevich <dkarpele@redhat.com>
-
- Apr 03, 2023
-
-
Thomas Woerner authored
Due to an API misbehaviour in FreeIPA, ipaexternalmembers need to be treated differently than other group members parameters. Even an empty array triggers all tests for external members, including the check for installed dcerpc bindings. Therefore ipagroup module has been changed to not set ipaexternalmember to an empty list if there are no external members to be added or removed.
-
- Mar 30, 2023
-
-
Rafael Guterres Jeffman authored
ipaclient: Defer krb5 configuration fix
-
Rafael Guterres Jeffman authored
ipareplica/server: Enable removal from domain with undeployment
-
Rafael Guterres Jeffman authored
Ansible lint fixes
-
- Mar 28, 2023
-
-
Thomas Woerner authored
New variables have been added to ipareplica and ipaserver role to enable the removal from the domein with the undeployment. `ipaserver_remove_from_domain` This enables the removal of the server from the domain additionally to the undeployment. `ipaserver_remove_on_server` The value defines the server/replica in the domain that will to be used to remove the server/replica from the domain if `ipaserver_ignore_topology_disconnect` and `ipaserver_remove_from_domain` are enabled. Without the need to enable `ipaserver_ignore_topology_disconnect`, the value will be automatically detected using the replication agreements of the server/replica. For the replica role it is possible to use the server variables, but also the replica versions: `ipareplica_remove_from_domain` and `ipareplica_remove_on_server`. The already existing parameters `ipaserver_ignore_topology_disconnect` and `ipaserver_ignore_last_of_role` have been added to the README files for server and replica with descriptions. The same for the replica versions of the parameters. The ipareplica role is not calling the `ipa-server-install` anymore, it is instead using (including) the server role for the task. The new module `ipaserver_get_connected_server` has been added to the server role to be able to get a connected server using the replication agreements. This module is only used if `ipaserver_ignore_topology_disconnect` is not needed.
-
- Mar 27, 2023
-
-
Thomas Woerner authored
The latest ansible-lint failes for the tasks that are using "when: sid_disabled.changed" with the error "Tasks that run when changed should likely be handlers.". As these tasks are tests and it would not make sense to use handlers here, the tasks have been marked as noqa 503.
-
Thomas Woerner authored
The cleanup of the root IPA cache was depending on the result of the ipaserver_enable_ipa and ipareplica_enable_ipa tasks. Instead of "when: something.changed" a handler should be used instead. As "/root/.ipa_cache" should be removed always (same in command line) the removal of the file has been moded into the always section and does not need a when anymore.
-
Thomas Woerner authored
The parameters nameservers and searchdomains had both the alias "cn". Both aliases have been removed.
-
Thomas Woerner authored
The alias for usercheck in argument_spec was "ipapwusercheck" instead of "ipapwdusercheck".
-
Thomas Woerner authored
The types for the parameters action and state have been missing in the DOCUMENTATION section of the module.
-
- Mar 24, 2023
-
-
Thomas Woerner authored
With the fix to defer creating the final krb5.conf on clients a bug has been introduced with ipaclient_fix_ca: The krb_name parameter that points to the temporary krb5 configuration was not added to the module Without this the server affinity is broken for allow_repair and additionally ipaclient_fix_ca could fail if krb5 configuration needs to be repraied and also CA needs to be fixed. The krb_name parameter has been added to ipaclient_fix_ca and is also properly set in tasks/install.yml.
-
Thomas Woerner authored
With the fix to defer creating the final krb5.conf on clients a bug has been introduced with ipaclient_setup_nss: The krb_name parameter that points to the temporary krb5 configuration was not added to the module. With a properly configured DNS (like for example IPA DNS) the krb TXT records have been present in the DNS configuration. These have been used automatically as a fallback and broke server affinity for the client. Without the TXT records creating the IPA NSS database failed with "Cannot find KDC for realm ..". The krb_name parameter has been added to ipaclient_setup_nss and is also properly set in tasks/install.yml.
-
- Mar 20, 2023
-
-
Thomas Woerner authored
ipauser: Better description of UID and GID parameters
-
Thomas Woerner authored
ipareplica role: Remove usage of undefined parameters.
-
- Mar 17, 2023
-
-
Rafael Guterres Jeffman authored
Some ipareplica role had a few module calls with parameters set like 'some_argument | default(omit)' that were not actually available in such modules. If a user provided 'some_argument', the paramater would then be passed to the module and ipareplica deployment would fail. By removing the parameters from the 'install' task, ipareplica deployment works even if the variables are set by the user.
-