Skip to content
  1. Dec 19, 2023
  2. Dec 15, 2023
  3. Dec 14, 2023
  4. Dec 08, 2023
  5. Dec 07, 2023
  6. Dec 06, 2023
    • Rafael Guterres Jeffman's avatar
      Bump minimum ansible-lint version to 6.22 · d2e0cad9
      Rafael Guterres Jeffman authored
      By the first quarter of 2024, all collections must pass ansible-lint
      tests run with version 6.22.x. This PR ensure that all ansible-freeipa
      tests depending on ansible-lint use a valid version of it.
      d2e0cad9
    • Rafael Guterres Jeffman's avatar
      Merge pull request #1186 from... · 9c735939
      Rafael Guterres Jeffman authored
      Merge pull request #1186 from t-woerner/test_host_random_conditional_statements_no_jinja2_templating
      
      test_host_random: No jinja2 templating in conditional statements
      9c735939
    • Rafael Guterres Jeffman's avatar
      ipaclient: Fix OTP error reporting · 22214daf
      Rafael Guterres Jeffman authored
      When deploying an IPA client with ipaclient, if an error occured while
      getting an OTP, no error message is logged, as the task that logs the
      error is not excuted due to the previous taks failure.
      
      By adding a 'rescue' section to the code block and moving the error
      reporting to this new section, we ensure that the proper error messages
      will be reported.
      22214daf
    • Thomas Woerner's avatar
      test_host_random: No jinja2 templating in conditional statements · 2c9ee7d8
      Thomas Woerner authored
      With ansible-core 2.14.12 using jinja2 templating in conditional
      statements with ansible_facts['fqdn'] is marked as unsafe and results in
      a failure.
      
      The issues with using jinja2 templating in conditional statements for
      asserts have been solved and a new server_fqdn fact has been added for
      ansible_facts['fqdn'].
      2c9ee7d8
  7. Dec 05, 2023
    • Thomas Woerner's avatar
    • Thomas Woerner's avatar
      ipaidp: Fix validation and reset of parameters · ff084fbd
      Thomas Woerner authored
      The uri parameters auth_uri, dev_auth_uri, token_uri, userinfo_uri and
      keys_uri have not been validated before. Also the base_url was not
      normalized. The auth_uri, dev_auth_uri, token_uri and userinfo_uri need
      to be set for new entries, but might be empty or empty string for reset
      or updates.
      
      The ipaidpclientsecret needs to be decoded from binary string in
      find_idp result to not trigger no change ipd_mod calls.
      
      The code for validate_uri and base_url normalization has been copied
      from the ipaserver idp plugin.
      
      ansible_freeipa_module:
      urlparse from urllib.parse with a fallback to six.moves.urllib.parse is
      imported and also exported. urlparse is needed for validate_uri in ipaidp
      module.
      
      Resolves: RHEL-17954, RHEL-17955, RHEL-17957 and RHEL-17958
      ff084fbd
  8. Nov 28, 2023
  9. Nov 24, 2023
  10. Nov 16, 2023
    • Thomas Woerner's avatar
      idoverride{user,group}: Fix delete_continue with state absent · 92e44f6a
      Thomas Woerner authored
      All tasks for idoverrideuser and idoverridegroup with state absent
      failed with "'continue' is required" when delete_continue was not set.
      
      This happended as delete_continue was internally None and continue: None
      was provided to the API.
      
      The fix is simply to use '"continue": delete_continue or False' so that
      continue is set to False in this case.
      92e44f6a
  11. Nov 11, 2023
    • Rafael Guterres Jeffman's avatar
      ipahost: Remove dangling dns records during test setup · 16c8ee87
      Rafael Guterres Jeffman authored
      When testing ipahost through the test playbooks, if there are previous
      DNS A/AAAA records, the test fails due to a false positive idempotence
      issue.
      
      This patch ensures that all DNS records for the test hosts are absent
      before test execution.
      
      This issue could be seen in the 2023-11-06 Azure Nightly pipeline
      execution.
      16c8ee87
  12. Nov 09, 2023
    • Rafael Guterres Jeffman's avatar
      utils/run-tests.sh: Replicate Azure's test grouping · 3109e9d1
      Rafael Guterres Jeffman authored
      When running ansible-freeipa's Azure pipelines for nightly and weekly
      tests, due to the amount of tests to execute, tests are grouped and
      executed in parallel jobs.
      
      Due to a still unkonwn issue, depending on the order the tests are
      executed, some random failures may occur and debugging them is hard due
      to current implementation of the tests.
      
      This patch adds support for replicating the tests of a specific Azure
      test group once the seed used to create groups and the group number are
      provided, allowing the test failures to be replicated on the developer's
      workstation where it can be more easily debugged.
      
      A new option is added to 'utils/run-tests.sh', '-A SEED.G' that is used
      to define the seed and group to replicate the tests. The seed is a date,
      with the format "YYYYMMDD", so, for example '-A 20230611.2' would
      execute the same tests, in the same order as the second group of tests
      for date 2023-06-11. To aid in usability 'YYYY-MM-DD' may also be used.
      
      When using '-A' neither '-s' (test suites) or specific tests (positional
      arguments) can be used.
      
      Also, to help fixing tests, an option to stop the tests on the first
      test failure ('-x') was added to the script.
      3109e9d1
  13. Nov 08, 2023
  14. Oct 23, 2023
  15. Oct 21, 2023
    • Thomas Woerner's avatar
      ipaidview: Fail to apply unknown (invalid) hosts · 21271949
      Thomas Woerner authored
      The task to apply an unknown (invalid) host to an idview was not failing
      as expected and only reported no change.
      
      A new host verification step has been added to fail before trying to
      apply invalid hosts. unapplying an invalid host is not failing as the
      invalid host is indeed not applied.
      21271949