- Jun 07, 2023
-
-
Rafael Guterres Jeffman authored
pwpolicy test: Fix maxsequence test
-
Thomas Woerner authored
The maxsequence test was testing maxrepeat. Therefore the typo reported with https://github.com/freeipa/ansible-freeipa/pull/1081 was never seen. The test has been fixed.
-
Thomas Woerner authored
Fix typo in ipapwpolicy.py
-
Thomas Woerner authored
ipapwpolicy: simplified and faster attribute verification
-
Jacob Cutright authored
The 'maxsequence' attribute was never applied as there was a typo when it was set. By fixing the field name, 'maxsequence' is correclty set. The failure was not seen before due to missing tests. The tests will be added in a separate PR.
-
Thomas Woerner authored
Upstream CI: Disable execution of pytest tests
-
Thomas Woerner authored
Don't allow the FQDN to match the domain on server installs
-
Thomas Woerner authored
ipacert module
-
Rafael Guterres Jeffman authored
Multiple service management
-
Sam Morris authored
There is a new certificate management module placed in the plugins folder: plugins/modules/ipacert.py The certificate module allows to request, revoke, release and retrieve certificates for users, hosts and services. Here is the documentation for the module: README-cert.md New example playbooks have been added: playbooks/cert/cert-hold.yml playbooks/cert/cert-release.yml playbooks/cert/cert-request-host.yml playbooks/cert/cert-request-service.yml playbooks/cert/cert-request-user.yml playbooks/cert/cert-retrieve.yml playbooks/cert/cert-revoke.yml New tests for the module can be found at: tests/cert/test_cert_client_context.yml tests/cert/test_cert_host.yml tests/cert/test_cert_service.yml tests/cert/test_cert_user.yml The module has been co-authored by Sam Morris (@yrro) and Rafael Guterres Jeffman (@rjeffman).
-
Thomas Woerner authored
The tests test_services_absent.yml, test_services_present.yml and test_services_present_slice.yml have been updated to use in memory data for testing instead of loading json files. This made is simpler to use variables from the playbook for example for fqdn host names. New tests for certificates with and without trailing new lines have been added for single service and multiple service handling.
-
Thomas Woerner authored
Denis added the multi service handling code. Therefore he should be listed in the file header.
-
Thomas Woerner authored
Any leading or trailing whitespace is removed while adding the certificates with serive_add_cert. To be able to compare the results from service_show with the given certificates we have to remove the white space also.
-
- Jun 06, 2023
-
-
Denis Karpelevich authored
Adding an option to create multiple services in one go. Adding tests (present/absent/without_skip_host_check) Copied from PR #1054 Signed-off-by:
Denis Karpelevich <dkarpele@redhat.com>
-
- Jun 05, 2023
-
-
Rafael Guterres Jeffman authored
If server FQDN matches the domain name, the installation will succeed, but DNS records will not work. If 'setup_dns: true' is used, there will be no A record for the host, only a NS record, and the PTR record will point to the domain name. Based on: https://github.com/freeipa/freeipa/pull/6853 Related to: https://pagure.io/freeipa/issue/9003
-
- May 30, 2023
-
-
Rafael Guterres Jeffman authored
Make Git ignore temporary and output files.
-
Thomas Woerner authored
upstream CI: Disable ansible-lint var-naming check
-
- May 16, 2023
-
-
Rafael Guterres Jeffman authored
Latest ansible-lint version (6.16.1) started to raise an error when variable names from within roles are not prefixed with the role name. Error: var-naming[no-role-prefix]. As Ansible sanity check does not enforce this, it will be disabled, for now on ansible-freeipa's upstream CI. A future effort to reduce the checks that are not being evaluated should be done as preparation for future Ansible Galaxy and Automation Hub requirements.
-
- May 15, 2023
-
-
Rafael Guterres Jeffman authored
The tests under 'tests/pytests' were a POC to bring tests that evaluate the result of playbook execution on the IPA environment. This is currently only implemented for dnszone tests, and similar test coverage is obtained with other tests. As there is an ongoing issue with Ansible's docker pluging ("the connection plugin 'docker' was not found"), which is stil under investigation, by removing the pytest tests we'll remove the consistent failures currently seen on upstream CI, and will not loose test coverage, specially if we take into account downstream tests. Also, a new version for the pytests will be available once multihost testing is implemented for upstream.
-
- May 08, 2023
-
-
Rafael Guterres Jeffman authored
tests/azure/templates/build_container.yml: Quote requests with version
-
Thomas Woerner authored
The version requirement for requests need to be quoted not to lead into a pip install command issue. This is related to PR #1089 (Pin requests to < 2.29 temporarily)
-
- May 05, 2023
-
-
Rafael Guterres Jeffman authored
Fix new ansible lint disallowes ignores
-
Thomas Woerner authored
The function exit_raw_json is a replacement for AnsibleModule.exit_json without flterting out values for no_log parameters. Ansible added checks for pylint to forbid print and also sys.exit and fails with ansible-bad-function. As the check is not known outside of ansible-test, the disable line needed also W0012: # pylint: disable=W0012,ansible-bad-function
-
Thomas Woerner authored
random_serial_numbers was missing the default value in the DOCMENTATION section.
-
Thomas Woerner authored
Automatic field numbering specification is not allowed by ansible-test.
-
Thomas Woerner authored
ansible is not allowing to use "#!/usr/bin/python". Due to a change in ansible-lint it is not possible to ignore the "bad" shebang.
-
Thomas Woerner authored
ansible requires to either use "#!/bin/bash -eu" or "#!/bin/bash -eux" for bash shebangs.
-
Thomas Woerner authored
The old ignore file ignore-2.12.txt is not needed and used anymore. The new files ignore-2.13.txt and ignore-2.14.txt are empty after ansible-lint made nearly all ignores disallowed. All the newly disallowed ignores need to be fixed. See https://github.com/ansible/ansible-lint/pull/3102
-
Rafael Guterres Jeffman authored
Pin requests to < 2.29 temporarily
-
Thomas Woerner authored
Due to https://github.com/docker/docker-py/issues/3113 requests need to be pinned below 2.29 as a temporary solution.
-
- Apr 28, 2023
-
-
Rafael Guterres Jeffman authored
tests/azure: Install molecule-plguins to get docker driver
-
- Apr 27, 2023
-
-
Thomas Woerner authored
The docker driver is not part of molecule 5.0.0 anymore. molecule-plugins need to be installed to get the driver.
-
- Apr 20, 2023
-
-
Rafael Guterres Jeffman authored
Fixes and enhancements for utils/new_module and templates
-
Rafael Guterres Jeffman authored
Create action group in collection for use with module_defaults
-
Thomas Woerner authored
The usage of module_defaults allows to reduce the size of the tests and to have the needed information in the tasks only. The default values for the parameters are automatically passed to the module by Ansible. It is not possible to use a module group for module_defaults as this could only be done with Ansible Collections. The tests are also used upstream and downstream without a collection. Without groups of a collection it is needed to add the defaults for all modules separately. Simple example: module_defaults: ipahost: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" Several module example using YAML anchors and aliases: module_defaults: ipahost: &ipa_module_defaults ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" ipauser: *ipa_module_defaults ipagroup: *ipa_module_defaults
-
Thomas Woerner authored
The documentation for "become" and "gather_facts" has been updated to make sure that these parameters are enabled only in new tests if it is really needed.
-
Thomas Woerner authored
The values "yes" and "no" will not be valid in the future for bool parameters. Therefore "yes" and "no" have been replaced by "true" and "false".
-
Thomas Woerner authored
The module action group <collection-prefix>.modules is created automatically while building the galaxy release. The action group can be used for module_defaults in this way: module_defauls: group/<collection-prefix>.modules: ipaadmin_password: SomeADMINpassword Example: module_defaults: group/freeipa.ansible_freeipa.modules: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" collections: - freeipa.ansible_freeipa
-
Thomas Woerner authored
The section module_defaults was not handled by utils/galaxyfy.py, also there was no verification that only roles and modules provided by ansible-freeipa are matched for prepending the collection prefix.
-
- Apr 18, 2023
-
-
Rafael Guterres Jeffman authored
Ignore vim .swp files and files generated by creating ansible-freeipa collection, when checking repository status.
-