- Jan 13, 2022
-
-
Thomas Woerner authored
hbacrule: Fix member management idempotence issues.
-
Thomas Woerner authored
iparole: Fix idempotence issues
-
Rafael Guterres Jeffman authored
ansible-test: Fix new findings
-
Thomas Woerner authored
ERROR: Found 6 pylint issue(s) which need to be resolved: ERROR: plugins/modules/ipaserver_prepare.py:395:4: invalid-name: Variable name "e" doesn't conform to snake_case naming style ERROR: roles/ipaserver/library/ipaserver_prepare.py:395:4: invalid-name: Variable name "e" doesn't conform to snake_case naming style ERROR: roles/ipaserver/module_utils/ansible_ipa_server.py:333:12: invalid-name: Variable name "ds" doesn't conform to snake_case naming style ERROR: roles/ipaserver/module_utils/ansible_ipa_server.py:348:12: invalid-name: Variable name "ds" doesn't conform to snake_case naming style ERROR: roles/ipaserver/module_utils/ansible_ipa_server.py:361:12: invalid-name: Variable name "ip" doesn't conform to snake_case naming style ERROR: roles/ipaserver/module_utils/ansible_ipa_server.py:364:12: invalid-name: Variable name "e" doesn't conform to snake_case naming style e has been replaced with err, ds with _ds, ip with _ip.
-
Rafael Guterres Jeffman authored
build-galaxy-release.sh: Use build dir, new options, checks, no reset
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
Members of hbacrule must be compared in a case insensitive manner. This patch fixes comparation of member parameters against existing members by converting parameters to lowercase. Also, there were some cases where a change with an empty set of members was issued to IPA API, leading to a result of 'changed: yes' when 'changed: no' was expected. The fix involved a refactoring of the member management code.
-
Rafael Guterres Jeffman authored
Add a task to FreeIPA facts task file to ensure that the variable 'ipaserver_domain' is set. The value is set form `ansible_facts['fqdn'], if available, or set to `ipa.test`, otherwise.
-
Thomas Woerner authored
hbacsvcgroup: Fix member management idempotence issues.
-
Thomas Woerner authored
Enable pylint for ansible-freeipa roles.
-
Thomas Woerner authored
pre-commit: Use system shellcheck.
-
Rafael Guterres Jeffman authored
pre-commit: Update ansible-lint version to v5.3.2
-
Rafael Guterres Jeffman authored
The official ShellCheck pre-commit hook uses a docker image, but it is, sometimes, unavailable. This change will use the system installed ShellCheck executable and does not depend on the image download.
-
Thomas Woerner authored
This fixes the import error for render_group from rich.console.
-
Thomas Woerner authored
Github Workflows: Run ansible-lint without an action.
-
Rafael Guterres Jeffman authored
We used a Github Action to run anisble-lint, but it has not have a release since 2019, and has not been updated in a year. This action is showing some issues when evaluating current playbooks. This PR substitute the action previously used with a shell script directly define in the workflow job. The ansible-core version was pinned to the currently available on Fedora 25, 2.11.6.
-
Rafael Guterres Jeffman authored
The test playbook provided adds some tests to verify if capitalization of role members does not influence on the module behavior. It also adds some tests to verify check_mode.
-
Rafael Guterres Jeffman authored
Renamed function and improved its documentation to better explain its use and goals.
-
Rafael Guterres Jeffman authored
IPA role members users, groups, hostgroups and privilege must be compared in a case insensitive way, and either are stored in lowercase or IPA API fixes the value for proper representation. This patch forces all comparisons of this values to be performed in lowercase, and also only modify the values if it is really needed.
-
Rafael Guterres Jeffman authored
IPA Role host members should always be lowercase and FQDN. This patch ensure that hosts are correctly compared and added as role members.
-
Rafael Guterres Jeffman authored
Some attributes retrieved by the IPA API backend don't change, and are used more than once, in different places of the code. IPA API domain is one of these attributes. This patch adds a cache to the attribute, so there is only one request for the API, improving access time to the object and alowing multiple calls with no efficiency penalty.
-
Rafael Guterres Jeffman authored
Service members in IPA role objects must be compared ignoring character capitalization, but are stored in a case preserving manner. This patch modifies the way service members are handled, creating a map between a lowercase version of the service parameter and the parameter itself, and using the map key to compare against existing services. The mapped value is then added as role member, if necessary.
-
Rafael Guterres Jeffman authored
Removed custom code used to create add/del lists in iparole in favor of ansible_freeipa_module functions, and custom result_handler, to reduce code duplication, as these methods have equivalent shared versions.
-
Rafael Guterres Jeffman authored
There was some unused code that was removed.
-
Rafael Guterres Jeffman authored
ansible-test fixes
-
- Jan 12, 2022
-
-
Thomas Woerner authored
ERROR: plugins/modules/ipaautomountmap.py:118:30: E203: whitespace before ':' ERROR: Found 1 compile issue(s) on python 2.6 which need to be resolved: ERROR: plugins/modules/ipasudorule.py:382:63: SyntaxError: {ensure_fqdn(value.lower(), default_domain) for value in host}
-
Thomas Woerner authored
sudorule: Create FQDN from single hostnames
-
Rafael Guterres Jeffman authored
This patch enables pylint evaluation for ansible-freeipa roles in both the local script 'utils/lint-check.sh' and in upstream CI.
-
Rafael Guterres Jeffman authored
Fix pylint warnings raised by enabling linter on ansible-freeipa roles.
-
Rafael Guterres Jeffman authored
This change configure pylint to ignore import modules that might not be availble during development, and ignore names that are relevant in the FreeIPA domain, even if they don't comply with PEP8.
-
Thomas Woerner authored
ipagroup: Refactor and fix group member management.
-
Rafael Guterres Jeffman authored
Enable ansible-test in github workflow
-
Thomas Woerner authored
This test is using the galaxy_importer from ansible project. The configuration file galaxy-importer.cfg is copied from linux-system-roles https://github.com/linux-system-roles/auto-maintenance/blob/master/\ lsr_role2collection/galaxy-importer.cfg The tests script has extra code to parse the output of the importer to highlight errors and to exit with a proper error code. The test can be used locally also with "sh tests/sanity/sanity.sh" New files: - .github/workflows/ansible-test.yml - tests/sanity/galaxy-importer.cfg - tests/sanity/sanity.sh
-
Thomas Woerner authored
The script is now using a build dir for the creation of the Ansible Collection. Additionally only files known to the fit repo are pulled in by default. The new "-a" option is pulling in all files from local repo. The new -k" option can be used to keep the build dir for verification of the changes to the files. The colleciton is placed into the main repo dir and no git reset --hard is used in the repo to preserve local changes.
-
Thomas Woerner authored
add module to create and manage automount keys
-
- Jan 11, 2022
-
-
Rafael Guterres Jeffman authored
Fixed several issues found during code review and change AutomountkeyModule to use IPAAnsibleModule instead of deprecated FreeIPABaseModule.
-
chrisp authored
There is a new automount key module placed in the plugins folder: plugins/modules/ipaautomountkey.py The server module allows to ensure presence and absence of automount keys. The module requires an existing automount location and map to place the key within. Here is the documentation for the module: README-automountkey.md New example playbooks have been added: playbooks/automount/automount-key-absent.yaml playbooks/automount/automount-key-present.yaml New tests for the module: tests/automount/test_automountkey.yml
-
Thomas Woerner authored
add module to create and manage automount maps
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
Currently, when adding an overlapping set of members causes playbook to fail as the already existing members are added twice. This patch refactors membership management by removing duplicate logic and handling all changes to members in a single place. This change removed code that was causing the execution failures.
-