- Jan 17, 2023
-
-
Rafael Guterres Jeffman authored
A few playbooks still had task name starting with lower case letters.
-
Rafael Guterres Jeffman authored
Ansible lint tests
-
Rafael Guterres Jeffman authored
pwpolicy: Fix new bool checks for IPA prior to 4.9.10
-
Rafael Guterres Jeffman authored
playbooks/automount: All playbooks should use .yml
-
Thomas Woerner authored
The playbooks automount-map-absent.yaml and automount-map-present.yaml have been using the wrong extention. The files have been renamed to use .yml now.
-
Thomas Woerner authored
-
Thomas Woerner authored
This replaces double spaces by single spaces, fixes spaces in slices, adds spaces before brackets and fixes bracket placing in when clauses.
-
Thomas Woerner authored
This change removes the space between join and (): "join ()" to "join()"
-
Thomas Woerner authored
The whole collection is tested with this change. Before it has been limited to the roles and plugins folder.
-
Thomas Woerner authored
The experimental tests is running several additional tests like for example to check module arg values. It fails everytime a variable is used to pass the value in. Examples: - playbooks/topology/add-topologysegments.yml:15: args[module]: value of suffix must be one of: domain, ca, domain+ca, got: {{ item.suffix }} - tests/host/test_host.yml:21: args[module]: value of ipaapi_context must be one of: server, client, got: {{ ipa_context | default(omit) }} The name template test is failing for every template use inside of a name. This is forcing to have only generic names and nothing specific in the log anymore. These two tests have been deactivated to have less overflow in the ansible-lint output.
-
Rafael Guterres Jeffman authored
pwpolicy: Fix tests for 'minlength: ""'
-
Rafael Guterres Jeffman authored
When clearing minimum length parameter, FreeIPA raises an error, and the error is different when executing the playbook in server or client context. Since the error message is evaluated in the text, both errors must be accepted as "not a failure", since ansible-freeipa did the correct call. Once https://pagure.io/freeipa/issue/9297 is fixed, the test must be updated to not accept any of these error messages.
-
- Jan 16, 2023
-
-
Rafael Guterres Jeffman authored
.github/workflows/lint.yml: ansible-lint needs collection source dir
-
Thomas Woerner authored
ansible-lint required to be run in a collection source directory with correct and working galaxy.yml As ansible-freeipa is not converted to a collection, the galaxy.yml file can not be used to create the collection. This needs to be done with utils/build-galaxy-release.sh. The script is fixing all the prefixes for the roles and modules in all the yml files and also example snippets and in the documentation. Therefore utils/build-galaxy-release.sh is called with the "-k" option to keep the directory that has been used to generate the collection with the script. Afterwards ansible-lint is run in this build directory.
-
Thomas Woerner authored
Fix ansible-test lint warnings in roles.
-
Thomas Woerner authored
With 4.9.10, the value of bools have been changed from "TRUE" and "FALSE" to real bool values. With IPA < 4.9.10 the new bool checks distcheck and usercheck failed the tests for enabling the checks with a "already enabled" error. A new version check altogether with providing the ansible module for gen_args has been added. The values True and False are now transformed into "TRUE" and "FALSE" for IPA < 4.9.10. The function bool_param has been renamed to bool_or_empty_param to match the int_or_empty_param and to have a more explaining name.
-
- Jan 13, 2023
-
-
Thomas Woerner authored
upstream ci: Update Ansible versions on Azure pipelines.
-
Thomas Woerner authored
pwpolicy: Allow clearing policy values.
-
Thomas Woerner authored
Update development and Github workflow tools.
-
- Jan 12, 2023
-
-
Rafael Guterres Jeffman authored
ansible-lint must ignore Azure configuration, and handle non-test files with the proper kind (tasks or playbook).
-
Rafael Guterres Jeffman authored
ansible-lint warns if Jinja2 templates are not used as the last item in a task name.
-
Rafael Guterres Jeffman authored
ansible-lint warns if set_fact sets a variable where the name is used or can be as a parameter for the role.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
Update Github workflow tools to match the versions on Fedora 37.
-
Rafael Guterres Jeffman authored
All values for pwpolicy can be cleared with an empty string in IPA CLI, and this behavior was missing in ansible-freeipa. As of today, there is an issue in FreeIPA that does not allow clearing 'minlength' policy. The is is tracked by the FreeIPA project through https://pagure.io/freeipa/issue/9297 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2150334
-
Rafael Guterres Jeffman authored
As we now have ansible-core 2.14 available through 'pip', the versions used for testing on Azure should be 2.12, 2.13 and 2.14, as Ansible keeps upstream support for the latest version plus the two previous ones. This patch update the version used in tests by increasing the version used by 1 (MINOR).
-
Rafael Guterres Jeffman authored
Update development tools to match Fedora 37 versions.
-
- Jan 11, 2023
-
-
Rafael Guterres Jeffman authored
ansible-lint warns if 'warn' key is used before block and always keys.
-
Rafael Guterres Jeffman authored
This patch fixes ansible-lint warns on jinja2 template spacing in roles
-
Rafael Guterres Jeffman authored
ansible-lint warns if task names don't start with an uppercase letter.
-
Rafael Guterres Jeffman authored
ansible-lint warns to avoid using free-form when calling module actions and ansible-freeipa roles used this form with 'ansible.builtin.fail'.
-
Rafael Guterres Jeffman authored
ansible-lint warns if version strings are used as numbers instead fo strings.
-
Rafael Guterres Jeffman authored
yamllint: All tasks need to be named
-
Thomas Woerner authored
yamllint is failing for unnamed tasks. All block and include_tasks tasks are now named.
-
- Jan 10, 2023
-
-
Rafael Guterres Jeffman authored
utils files: Support builtins with ansible.builtin. prefix
-
- Jan 09, 2023
-
-
Thomas Woerner authored
The ansible.builtin. prefix was not supported. Therefore tasks have not been identified properly.
-
Thomas Woerner authored
The ansible builtins are using the ansible.builtin. prefix now, but galaxyfy was not supporting the prefix. Therefore vars in set_fact tasks got the collection prefix and include_role tasks have not been handled correctly.
-
- Jan 05, 2023
-
-
Thomas Woerner authored
upstream ci: Allow tasks to retry in case of connection failure.
-
Rafael Guterres Jeffman authored
Use netgroup_find instead of netgroup_show to workaround IPA bug.
-