- May 25, 2021
-
-
Thomas Woerner authored
The new argument ignore has been added to compare_args_ipa to ignore attributes while comparing attributes of the user args and the object args returned from IPA find or show command. This code is using changes from - Wolskie in PR #392 - jake2184 in PR #486
-
Rafael Guterres Jeffman authored
tests/azure: Install community.docker Ansible collection
-
Thomas Woerner authored
The test preparation failed with "the connection plugin 'community.docker.docker' was not found" in "Setup test container". "ansible-galaxy collection install community.docker" has been added to tests/azure/templates/playbook_tests.yml and tests/azure/templates/pytest_tests.yml
-
- May 21, 2021
-
-
Rafael Guterres Jeffman authored
dnszone: Fix no modifications to be performed for serial
-
Rafael Guterres Jeffman authored
host: Fix DNS resource record not found error
-
Thomas Woerner authored
A dnszone_mod call is always made to set the serial for a zone even if this serial is set already. A check is added to make sure that the serial is only set with dnszone_mod if there is no serial set or if the serial is different.
-
- May 20, 2021
-
-
Rafael Guterres Jeffman authored
ipasudorule: Fix category reset for idempotency
-
Thomas Woerner authored
The "DNS resource record not found" error occurs when a host arecord or aaaarecord member is ensured to be absent and no dnsrecord entry for the host exists. The arecord or aaaarecord item are removed from dnsrecord_args if the record is not defined in res_find_dnsrecord.
-
Thomas Woerner authored
A repeated category reset of usercategory, hostcategory, cmdcaterory, runasusercategory and hostcategory is resulting in the error "no modifications to be performed". The empty categories are now removed from the args if the category is not set in the sudorule.
-
- May 19, 2021
-
-
Rafael Guterres Jeffman authored
ansible-doc-test: ANSIBLE_LIBRARY needs to be set internally
-
Thomas Woerner authored
Currently ansible-doc-test is run silently. There is no output about the checked files in the test results. Therefore verbose mode has been enabled.
-
Thomas Woerner authored
ANSIBLE_LIBRARY needs to be set properly for new Ansible version 4.0.0 to make sure that it is able to find the module that is checked. For every file that needs to be checked, there is a separate ansible-doc call. ANSIBLE_LIBRARY is set using os.path.dirname on the module_path.
-
Thomas Woerner authored
Currently ansible-doc-test is run silently. There is no output about the checked files in the test results. Therefore verbose mode has been enabled.
-
Thomas Woerner authored
With latest Ansible (4.0.0) it is needed to have a complete path for ANSIBLE_LIBRARY. It is not good to hard code this in the .pre-commit-config.yaml file for plugins and also all roles. Instead it will be set in ansible-doc-test as it knows the path for each file that is checked.
-
Rafael Guterres Jeffman authored
New server management module
-
- May 18, 2021
-
-
Rafael Guterres Jeffman authored
ansible_doc_test pre commit: Set ANSIBLE_LIBRARY to test current repo
-
Thomas Woerner authored
There is a new server management module placed in the plugins folder: plugins/modules/ipaserver.py The server module allows to ensure presence and absence of servers. The module requires an existing server, the deployment of a new server can not be done with the module. DNSName has been added to ansible_freeipa_module in plugins/module_utils as this is used for locations. Here is the documentation for the module: README-server.md New example playbooks have been added: playbooks/server/server-absent-continue.yml playbooks/server/server-absent-force.yml playbooks/server/server-absent-ignore_last_of_role.yml playbooks/server/server-absent-ignore_topology_disconnect.yml playbooks/server/server-absent.yml playbooks/server/server-hidden.yml playbooks/server/server-location.yml playbooks/server/server-no-location.yml playbooks/server/server-no-service-weight.yml playbooks/server/server-not-hidden.yml playbooks/server/server-present.yml playbooks/server/server-service-weight.yml New tests for the module: tests/server/test_server.yml Change in module_utils/ansible_freeipa_module: DNSName is imported from ipapython.dnsutil and also added to __all__
-
Thomas Woerner authored
It is needed to set ANSIBLE_LIBRARY to make sure that the current repo is tested.
-
- May 12, 2021
-
-
Thomas Woerner authored
workaround 2.9 controller import issues
-
- May 11, 2021
-
-
Thomas Woerner authored
Line too long and too many blank line errors and a trailing whitespace have been fixed.
-
Thomas Woerner authored
-
- May 06, 2021
-
-
Thomas Woerner authored
Fix privilege with permisions
-
- May 05, 2021
-
-
Rafael Guterres Jeffman authored
Module was raising exceptions when trying to create a new privilege with permissions. This change fixes the behavior and ensuure idempotence with trying to create a privilege with the same values. Tests for this behavior have been appended to: tests/privilege/test_privilege.yml
-
Rafael Guterres Jeffman authored
There were no test for the arguments of compare_args_ipa() to check if they were `None`, and they were used in contexts where `None` would raise exceptions. A test was added to return `False` if only one of the parameters is `None`, and `True` if both are None.
-
- May 04, 2021
-
-
Thomas Woerner authored
Force plugins to execute using LANGUAGE='C'.
-
Rafael Guterres Jeffman authored
IPA translates exception messages and Ansible uses controller's language to execute plugins on target hosts, and since ansible-freeipa uses Exceptions messages to detect some errors and/or states, using any language that has a translation for the required messages may cause the plugin to misbehave. This patch modifies ansible_freeipa_module in plugin/module_utils to force the use of "C" as the language by setting the environment variable LANGUAGE. Tests were added to verify the correct behavior: tests/environment/test_locale.yml The first test will fail, if ansible_freeipa_module is not patched, with the message: host_show failed: nonexistent: host nicht gefunden This issue is not present if the language selected does not provide a translation for the eror message. This patch does not fix encoding issues that might occur in certain releases (e.g.: CentOS 8.3). Fix #516
-
- May 03, 2021
-
-
Thomas Woerner authored
Tests: Change inline certificates to file lookups in ipaservice tests.
-
Rafael Guterres Jeffman authored
Tests for service certificates were still using pre-generated certificate files. This patch uses the same approach as other tests, it generates a certficate, when needed, and use file lookup.
-
Thomas Woerner authored
Fix execution of Github Workflow to verify ansible docs.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
The Github workflow Ubuntu images do not provide Ansible pre-installed anymore, and this patch forces its installation through Python's pip. Different jobs were created to test documentation with different versions of Ansible, currently 2.9 and the latest available.
-
Rafael Guterres Jeffman authored
tests/azure: Set ANSIBLE_LIBRARY, deactivate NTP
-
Thomas Woerner authored
In CentOS 8 and also Fedora the configuration and start of chrony fails with Fatal error : adjtimex(0x8001) failed : Operation not permitted For more information: https://bugzilla.redhat.com/show_bug.cgi?id=1772053 NTP will not be needed before a separate namespace is used for clocks.
-
Thomas Woerner authored
The ANSIBLE_LIBRARY environment variable needs to point to molecule directory.
-
- Apr 08, 2021
-
-
Rafael Guterres Jeffman authored
Use ansible_facts variable
-
- Apr 07, 2021
-
-
Rafael Guterres Jeffman authored
change variable in get_ipabackup_dir.yml and update README.md
-
Ivan PANICO authored
-
- Mar 19, 2021
-
-
Grzegorz Grasza authored
Without this change the "Import variables specific to distribution" tasks fail with "Could not find file on the Ansible Controller..." on environments with inject facts disabled. This changes the tests to run with ansible with inject_facts_as_vars = false and fixes other roles and playbooks.
-
- Feb 22, 2021
-
-
Varun Mylaraiah authored
ipaclient: Do not fail on rmkeytab error #7
-