Skip to content
  1. Dec 13, 2021
  2. Dec 10, 2021
  3. Dec 09, 2021
  4. Dec 08, 2021
    • jh23453's avatar
      correct comment in example playbook · 25b41b7e
      jh23453 authored
      Insert "ensure maxlife is set to 49 in global policy" instead of the wrong comment from cut&paste.
      25b41b7e
    • jh23453's avatar
      Login shell is called defaultshell and not defaultlogin · b53f2a08
      jh23453 authored
      The example didn't work for me with the following error (on freeipa 4.9.8):
      
      TASK [display default login shell] **************************************************************************************************
      fatal: [freeipa1.example.org]: FAILED! => {"msg": "
      The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'defaultlogin'
      
      Using the correct variable defaultshell works for me.
      b53f2a08
  5. Nov 30, 2021
  6. Nov 29, 2021
  7. Nov 26, 2021
  8. Nov 25, 2021
  9. Nov 24, 2021
  10. Nov 16, 2021
    • Rafael Guterres Jeffman's avatar
      DNSZone: Use IPAAnsibleModule. · 2f9791f6
      Rafael Guterres Jeffman authored
      As FreeIPABaseModule is deprecated, change DNSZone to use
      IPAAnsibleModule.
      2f9791f6
    • Rafael Guterres Jeffman's avatar
      automountlocation: Use IPAAnsibleModule. · f4110452
      Rafael Guterres Jeffman authored
      As FreeIPABaseModule is deprecated, change AutomountLocation to use
      IPAAnsibleModule.
      f4110452
    • Rafael Guterres Jeffman's avatar
      Deprecate FreeIPABaseModule in favor of IPAAnsibleModule. · d8199447
      Rafael Guterres Jeffman authored
      This patch add several deprecate warnings to FreeIPABaseModule, and
      creates adapters to ease conversion of client classes to
      IPAAnsibleModule.
      
      There is no 'ipa_commands' management in IPAAnsibleModule, as 'command's
      is a list of tuples containing '(command, name, args)', and should be
      managed by the module itself. Commands with no arguments should use an
      empty dictionary as 'args'.
      
      The 'ipa_run' method should be replaced by:
      
      ```
      exit_args = {}
      ipaapi_context = self.params_get("ipaapi_context")
      with self.ipa_connect(context=ipaapi_context):
          self.check_ipa_params()
          self.define_ipa_commands()
          changed = self.execute_ipa_commands(
                      self.ipa_commands,
                      result_handler=my_custom_handler,
                      exit_args=exit_args
                  )
      self.exit_json(changed=changed, **exit_args)
      ```
      
      The 'process_command_result' method should be changed to a result
      handler:
      
      ```
      def my_result_handler(self, result, command, name, args, exit_args):
          """Process command result.""'
      ```
      
      Use of 'ipa_params' should be replaced by IPAAnsibleModule.params_get.
      If 'get_ipa_command_args' is used, then the mapping can be created with
      class IPAParamMapping (formelly AnsibleFreeIPAParams), which also
      enables the same property-like usage of 'ipa_params':
      
      ```
      param_mapping = IPAParamMapping(module, mapping)
      ```
      
      The goal is to have all ansible-freeipa modules using the same codebase,
      reducing code duplication, and allowing better object composition, for
      example, with the IPAParamMapping class.
      d8199447
    • Rafael Guterres Jeffman's avatar
      CI: Test modules against different Ansible versions. · 612b6076
      Rafael Guterres Jeffman authored
      Currently, upstream CI test documentation against different Ansible
      versions, but playbook tests are only executed with Ansible 2.9 series.
      This patch add support for running playbook tests against Ansible 2.9,
      ansible-core 2.11, and against latest version of Ansible.
      
      As running all the tests for every PR would take too long, the tests
      for every PR use only Anisble 2.9, and are executed on Fedora-latest
      and CentOS 7 and 8.
      
      A new pipeline for nightly tests was added, which runs the tests in the
      same distros, using Ansible 2.9, latest and Ansible-core 2.11.
      612b6076
  11. Nov 12, 2021