- Dec 13, 2021
-
-
Thomas Woerner authored
Deprecate FreeIPABaseModule in favor of IPAAnsibleModule.
-
- Dec 10, 2021
-
-
Thomas Woerner authored
yamllint: Fix missing document start.
-
Rafael Guterres Jeffman authored
Recently added Ubuntu configuration filesi for roles miss document start marker.
-
- Dec 09, 2021
-
-
Thomas Woerner authored
Fix role issues in Debian based distros.
-
Thomas Woerner authored
correct comment in example playbook
-
Thomas Woerner authored
Login shell is called defaultshell and not defaultlogin
-
Thomas Woerner authored
upstream ci: Build images for CentOS 9 Stream.
-
- Dec 08, 2021
-
-
jh23453 authored
Insert "ensure maxlife is set to 49 in global policy" instead of the wrong comment from cut&paste.
-
jh23453 authored
The example didn't work for me with the following error (on freeipa 4.9.8): TASK [display default login shell] ************************************************************************************************** fatal: [freeipa1.example.org]: FAILED! => {"msg": " The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'defaultlogin' Using the correct variable defaultshell works for me.
-
- Nov 30, 2021
-
-
Rafael Guterres Jeffman authored
This patch add support for building testing images for CentOS 9 Stream.
-
- Nov 29, 2021
-
-
Rafael Guterres Jeffman authored
When using ipaclient role under Debian 10 (Buster), it is required that the python interpreter is set to Python 2.7 as freeipa-client package pulls in Python 2.7 dependencies, and does not work with Python 3. This patch adds configuration to properly set python interpreter. Based on the work by Marc Richter (@The-Judge on Github). Fix issue #607.
-
Rafael Guterres Jeffman authored
Ubuntu Bionic Beaver must use python2 as Python interpreter due to the way python-ipalib package is defined. Before using the role for installation, one must install package python2.7 before executing this role. Based on the work by Manuel Laurent (@mlaurent205 on Github).
-
Thomas Woerner authored
ipaservice: Use IPAAnsibleModule member result handler.
-
Thomas Woerner authored
ansible_module_utils: Add method to get parameters as lowercase.
-
- Nov 26, 2021
-
-
Rafael Guterres Jeffman authored
Use IPAAnsibleModule default error handler for member arguments instead of a custom one.
-
- Nov 25, 2021
-
-
Rafael Guterres Jeffman authored
When managing ipaservice members, gen_add_del_lists, gen_add_list and get_intersection_list should be used and the result tested for empty sets so already existing or missing members are not added or removed again. This changes fixes this behavior, by applying these functions to all ipaservice members.
-
Thomas Woerner authored
CI: Add supoprt for Shellcheck
-
Thomas Woerner authored
automember: Fix behavior of unused parameters.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
Add shellcheck as an action to be executed on every PR.
-
Rafael Guterres Jeffman authored
`Shellcheck` is a linter tool for shell scripts that is also used in Automation Hub. This change adds a pre-commit hook to run shellcheck on shell scripts. The hook uses a Docker image, which needs to be downloaded on the first run. It works well with `podman`.
-
Rafael Guterres Jeffman authored
build-galaxy-release: Cleanup of ipabackup_get_backup_dir.py link
-
- Nov 24, 2021
-
-
Thomas Woerner authored
CI: Test modules against Ansible core 2.11 and latest Ansible
-
Thomas Woerner authored
The link for plugins/modules/ipabackup_get_backup_dir.py from roles/ipabackup/library/ipabackup_get_backup_dir.py was left over after the script finished.
-
Rafael Guterres Jeffman authored
Changes needed to pass Automation Hub tests
-
Thomas Woerner authored
__metaclass__ is required for all plugins to be able to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
Thomas Woerner authored
This patch is needed to pass Automation Hub tests.
-
- Nov 16, 2021
-
-
Rafael Guterres Jeffman authored
As FreeIPABaseModule is deprecated, change DNSZone to use IPAAnsibleModule.
-
Rafael Guterres Jeffman authored
As FreeIPABaseModule is deprecated, change AutomountLocation to use IPAAnsibleModule.
-
Rafael Guterres Jeffman authored
This patch add several deprecate warnings to FreeIPABaseModule, and creates adapters to ease conversion of client classes to IPAAnsibleModule. There is no 'ipa_commands' management in IPAAnsibleModule, as 'command's is a list of tuples containing '(command, name, args)', and should be managed by the module itself. Commands with no arguments should use an empty dictionary as 'args'. The 'ipa_run' method should be replaced by: ``` exit_args = {} ipaapi_context = self.params_get("ipaapi_context") with self.ipa_connect(context=ipaapi_context): self.check_ipa_params() self.define_ipa_commands() changed = self.execute_ipa_commands( self.ipa_commands, result_handler=my_custom_handler, exit_args=exit_args ) self.exit_json(changed=changed, **exit_args) ``` The 'process_command_result' method should be changed to a result handler: ``` def my_result_handler(self, result, command, name, args, exit_args): """Process command result.""' ``` Use of 'ipa_params' should be replaced by IPAAnsibleModule.params_get. If 'get_ipa_command_args' is used, then the mapping can be created with class IPAParamMapping (formelly AnsibleFreeIPAParams), which also enables the same property-like usage of 'ipa_params': ``` param_mapping = IPAParamMapping(module, mapping) ``` The goal is to have all ansible-freeipa modules using the same codebase, reducing code duplication, and allowing better object composition, for example, with the IPAParamMapping class.
-
Rafael Guterres Jeffman authored
Currently, upstream CI test documentation against different Ansible versions, but playbook tests are only executed with Ansible 2.9 series. This patch add support for running playbook tests against Ansible 2.9, ansible-core 2.11, and against latest version of Ansible. As running all the tests for every PR would take too long, the tests for every PR use only Anisble 2.9, and are executed on Fedora-latest and CentOS 7 and 8. A new pipeline for nightly tests was added, which runs the tests in the same distros, using Ansible 2.9, latest and Ansible-core 2.11.
-
- Nov 12, 2021
-
-
Thomas Woerner authored
ipaprivilege: Fix permissions handling.
-