- Mar 22, 2022
-
-
Rafael Guterres Jeffman authored
Newer versions of pylint warns about not using f-strings, but those are not supported in Python 2, which ansible-freeipa still need to support.
-
- Mar 03, 2022
-
-
Varun Mylaraiah authored
module_params_get*: Fail on empty string in string list parameters
-
- Feb 28, 2022
-
-
Rafael Guterres Jeffman authored
automember: Remove debug output
-
Thomas Woerner authored
The warn debug line was added with "Add automember default group handling" d2648b14
-
Thomas Woerner authored
The parameters user_auth_type, pac_type and configstring are allowing to use "" to reset to the default value or for configstring to set an empty list. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. Additionally empty pac_type, user_auth_type and domain_resolution_order have been added to exit_args as if they have not been set.
-
- Feb 25, 2022
-
-
Thomas Woerner authored
The parameter auth_ind is allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working.
-
Thomas Woerner authored
The parameters auth_ind and pac_type are allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. An idempotency issue with pac_type has been found with the test and fixed additionally.
-
- Feb 24, 2022
-
-
Thomas Woerner authored
The parameters userauthtype and sshpubkey allowing to use "" to reset to the default value. The new check in params_get is not allowing to use empty strings in lists, therefore allow_empty_string=True had to be added to the call. A test has been added to verify that the empty strings are supported and working. An idempotency issue with sshpubkey has been found with the test and fixed additionally.
-
Thomas Woerner authored
So far it is possible to pass list parameters with empty strings to the modules. The use of empty strings in list does not make a lot of sense, though. The simple solution is to add a check to module_params_get for empty strings in returned lists. The option allow_empty_string can be set to True to allow an empty string in the list with a list len of 1. The option defaults to False. It is needed for some parameters the modules, like for example userauthtype in the user module. It is using "" to reset to the default value. module_params_get_lowercase has been changed to use module_params_get to have one place to add the check. Due to an issue in Ansible it is possible to use the empty string "" for lists with choices, even if the empty list is not part of the choices. Ansible issue https://github.com/ansible/ansible/issues/77108
-
- Feb 21, 2022
-
-
Thomas Woerner authored
hbacrule: Allow clearing members with empty lists.
-
- Feb 17, 2022
-
-
Thomas Woerner authored
IPAAnsibleModule: Provide base configuration for delete_continue.
-
Rafael Guterres Jeffman authored
Allows the creation of IPAAnsibleModule objects with specific `ipa_arguments` which are defined in a dictionary of argumets in the base class. Every module using `delete_continue` should provide the proper behavior and the module must be instantiated with: ansible_module = IPAAnsibleModule( ..., ipa_arguments=["delete_continue"] ) The plugin documentation must be extended with 'ipamodule_arguments.delete_continue'.
-
Thomas Woerner authored
upstream ci: Fix scenario for Centos 8 Stream with Ansible 2.11.
-
- Feb 16, 2022
-
-
Thomas Woerner authored
upstream ci: Rename CentOS 9 pipelines jobs to c9s.
-
Rafael Guterres Jeffman authored
Changed scenario from old CentOS 8 (centos-8) to current Centos 8 Stream (c8s).
-
Rafael Guterres Jeffman authored
The correct name for upcoming release of CentOS is CentOS 9 Stream, usually abbreviated to 'c9s'. As we need to differentiate from the stream and the standard versions, this patch modifies the Azure piipelines to use 'c9s' instead of 'CentOS 9'.
-
Thomas Woerner authored
ansible-lint: Remove warning on 'ignore_errors'.
-
Thomas Woerner authored
upstream CI: Fix container builds in face of Ansible and CentOS changes.
-
Thomas Woerner authored
upstream CI: Enable CentOS 8 Stream for PR and nightly tests.
-
Thomas Woerner authored
upstream ci: enable ansible-core 2.12 for CentOS 9 Stream.
-
- Feb 15, 2022
-
-
Rafael Guterres Jeffman authored
The test for dnsrecord creates a DNSSEC zone, and was forcing the task to ignore errors using `ignore_errors: true`. The test environment should be clean at that point, and without the zone, tests would fail, so there is no need to keep the attribute set. If the task fails, it should be fixed.
-
Rafael Guterres Jeffman authored
molecule: Disable prerun for normal tests
-
Rafael Guterres Jeffman authored
With the removal of CentOS 8 container, the available Fedora latest image will be used for tests, if a specific container is not given.
-
Rafael Guterres Jeffman authored
Newer Ansible versions will require at least Python 3.8 to be used, and the build containers pipeline was requiring Python 3.6, which is EOL. This patch requests the latest Python version available for the controller, and allows it to be configured to a specific version if, and when, needed.
-
Rafael Guterres Jeffman authored
Add configuration to build a testing CentOS 8 stream image and to execute upstream tests using that image in pull requests (Ansible 2.9) and on the nightly tests (all supported Ansible versions).
-
Rafael Guterres Jeffman authored
CentOS 9 Stream package pytho3-devel was not installable, and as it is not required for the testing container, it was removed from the Dockerfile used to create the image.
-
Rafael Guterres Jeffman authored
This disables the generation of the collection using the default galaxy.yml. The installation of the generated collection fails with invalid version A.B.C. The collection is not used when building containers and the generated collection is not using proper name and namespace in the collection files.
-
Rafael Guterres Jeffman authored
Currently the pipeline used to create test containers is using Python 3.6.15, and Ansible 2.12 requires, at least, Python 3.8. This change adds a new parameter to build container template, `python_version`, which is set by default to '3.x', meaning it will use the latest Python version available (for version 3) if the parameter is not explicitly set.
-
Thomas Woerner authored
This disables the generation of the collection using the default galaxy.yml. The installation of the generated collection fails with invalid version A.B.C. The collection is not used in the tests and the generated collection is not using proper name and namespace in the collection files. Note: utils/build-galaxy-releasesh needs to be used to generate the correct collection.
-
Rafael Guterres Jeffman authored
Merge pull request #773 from t-woerner/servicedelegation_do_no_fail_on_not_existing_members_with_state_absent servicedelegation: Do not fail for not existing members with state absent
-
- Feb 14, 2022
-
-
Thomas Woerner authored
Ensuring absence of members (services and targets) that do not exist may not fail as they are not members for servicedelegationtarget and servicedelegationrule. servicedelegation_normalize_principals in ansible_freeipa_module has been extended with a check_exists argument that defaults to False. state == "present" is now given as this argument to turn on the element exists check only if elements should be added.
-
Rafael Guterres Jeffman authored
build-galaxy-release: Fix refs for all doc_fragments in plugins/doc_fragments
-
Rafael Guterres Jeffman authored
Fix new ansible-lint findings
-
Thomas Woerner authored
The upper case name has been reported as issues by new ansible-lint.
-
Thomas Woerner authored
The upper case name has been reported as issues by new ansible-lint.
-
Thomas Woerner authored
The upper case name has been reported as issues by new ansible-lint.
-
Thomas Woerner authored
The unnamed tasks have been reported as issues by new ansible-lint.
-
Thomas Woerner authored
The unnamed tasks have been reported as issues by new ansible-lint.
-
Thomas Woerner authored
The script now fixes the references for all doc_fragments in the plugins/doc_fragments folder. So far it was only fixing the references for ipamodule_base_docs. PR #762 (automount location: add support for delete_continue) added an other doc_fragment and the references have not been fixes as needed.
-
- Feb 11, 2022
-
-
Rafael Guterres Jeffman authored
test_servicedelegationtarget.yml: Added list tests
-