- Jan 18, 2021
-
-
Thomas Woerner authored
A wrong variable was used inside of the while IFS read loops. This prevented that the modules, playbooks, tasks, example playbooks and also tests have been adapted for the galaxy release naming scheme.
-
Varun Mylaraiah authored
Fix adding A/AAAA records with reverse in compatibility mode.
-
Varun Mylaraiah authored
Improve ipapermission member management.
-
- Jan 12, 2021
-
-
Rafael Guterres Jeffman authored
In `ipapermission` plugin, Some attributtes were not being managed when `action: member` was enabled. This patch enable member management for `right`, `rawfilter`, `filter, and fixes management of `memberof`. Fix issue #489
-
- Jan 11, 2021
-
-
Rafael Guterres Jeffman authored
When adding A or AAAA records using the compatibility mode with Ansible's community general plugin, the reverse (PTR) record was added, but the A/AAAA record was not. This patch fixes the behavior. Fix issue #491
-
Rafael Guterres Jeffman authored
Fix typo in README-permission.md
-
Thomas Woerner authored
There is a typo "Eure" instead of "Ensure" in the rename task.
-
- Jan 08, 2021
-
-
Rafael Guterres Jeffman authored
ipapermission: Fix attrs and drop privilege handling
-
Thomas Woerner authored
ipadnszone: Fix values accepted by allow_transfer and allow_query.
-
Thomas Woerner authored
Change test requirement testinfra to pytest-testinfra.
-
Thomas Woerner authored
The attrs handling was not complete and did not support to ensure presence or absence of attributes with action:member. The includedattrs and excludedattrs parameters have not been added with this change as the use of attrs will automatically set includedattrs and excludedattrs. The includedattrs and excludedattrs parameters are only usable for managed permissions and duplicating attrs. The permission module may not handle privileges. An IPA internal only API has been used for this. The prvilege variable and all related code paths have been removed. Fixes: #424 ([Permission Handling] Not able to add additional attributes with existing attributes) Fixes: #425 ([Permission Handling] Not able to add member privilege while adding permission)
-
- Jan 07, 2021
-
-
Thomas Woerner authored
Fix changing the type of an existing Vault.
-
Thomas Woerner authored
Fix handling members in ipa role.
-
Thomas Woerner authored
Update modules to support check_mode
-
Rafael Guterres Jeffman authored
There are some issues using a combination of `lookup('file')` and the `b64encode` filter in Ansible, making tests unstable. This change removes the usage of b64encode when loading public and private keys from files in the Vault test playbooks.
-
- Jan 06, 2021
-
-
Eric Nothen authored
Added code to the ipa* plugins to support Ansible's check_mode, by means of a clean exit before the execution of the actual list of commands that would otherwise create/update/delete IPA servers and/or its resources.
-
- Jan 04, 2021
-
-
Rafael Guterres Jeffman authored
Current implementation does not allow the change of an existingi Vault type. To allow it, data is retrieved from the current vault, the vault is modifiend, and then, data is stored again in the new vault. Due to changing the process of modifying a vault, this change also fixes the update of asymmetric vault keys. To change the key used, the task must provide the old private key, used to retrieve data, and the new public_key, used to store the data again. A new alias was added to public_key (new_public_key) and public_key_file (new_public_key_file) so that the playbook better express the intention of the tak. Vault tests have been updated to better test against the new update process, and a new test file has bee added: tests/vault/test_vault_change_type.
-
- Dec 29, 2020
-
-
Rafael Guterres Jeffman authored
In FreeIPA CLI, The attributes `allow_query` and `allow_transfer` can hold IPv4 or IPv6 address or network address, and the values `none` and `any`. This patch adds support for network addresses, `none` and `any`, which were not supported. Fix issue #475.
-
- Dec 22, 2020
-
-
Rafael Guterres Jeffman authored
When adding new members to a role, the existing members were removed. The correct behavior for the "member" action is to add those members, and substitute the existing ones. This patch fixes this behavior. Fix #409, #411, #412, #413
-
Rafael Guterres Jeffman authored
According to the testinfra changelog, since version 6.0.0, testinfra is know as pytest-testinfra, and the use of testinfra is deprecated. This change will prevent future isses when updating requirements using `pip`. Ref: https://testinfra.readthedocs.io/en/latest/changelog.html
-
Thomas Woerner authored
Fix typo
-
Thomas Woerner authored
Faster pre-commit by running ansible-lint only when necessary.
-
Thomas Woerner authored
Tools flake8 bugbear
-
- Dec 21, 2020
-
-
Nils Philippsen authored
Signed-off-by: Nils Philippsen <nils@redhat.com>
-
- Dec 17, 2020
-
-
Rafael Guterres Jeffman authored
Bugbear is a plugin for Flake8 finding likely bugs and design problems. It contain warnings that don't belong in pyflakes and pycodestyle, and do not have a PEP or standard behind them. Ref: https://github.com/PyCQA/flake8-bugbear
-
- Dec 16, 2020
-
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
This commit change the name of a variable to make it more clear that it is not required in the for-loop, removing a bugbear B007 warning.
-
Rafael Guterres Jeffman authored
Running flake8 with bugbear enable found an extra for-loop that is not needed. The for-loop was removed, fixing bubear's warning.
-
- Dec 15, 2020
-
-
Rafael Guterres Jeffman authored
This patch disables ansible-lint `always_run` flag, as this was making patches that did not change any YAML file take longer in the pre-commit step, as ansible-lint was executed with no parameter, thus, searching and evaluating all YAML files in the repository. With this change, if no YAML file is modified, ansible-lint is skipped.
-
- Dec 10, 2020
-
-
Thomas Woerner authored
covscan error[SC2068]: Fix unquoted array expansions.
-
- Dec 09, 2020
-
-
Rafael Guterres Jeffman authored
utils/gen_modules_docs.sh: Fix covscan findings
-
Rafael Guterres Jeffman authored
error[SC2068]: Double quote array expansions to avoid re-splitting elements.
-
Rafael Guterres Jeffman authored
utils/new_module: Fix covscan findings
-
Rafael Guterres Jeffman authored
utils/build-galaxy-release.sh: Fix covscan findings
-
Thomas Woerner authored
error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang.
-
Thomas Woerner authored
warning[SC2166]: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
-
Thomas Woerner authored
warning[SC2044]: For loops over find output are fragile. Use find -exec or a while read loop. warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
-
- Dec 08, 2020
-
-
Thomas Woerner authored
yamllint: Run yaml linter only on modified files in pre-commit.
-
- Dec 02, 2020
-
-
Thomas Woerner authored
ipabackup: Fix undefined vars for conditions in shell tasks without else
-
- Dec 01, 2020
-
-
Thomas Woerner authored
The use of conditions in shell tasks without else clause is failing on some systems with an undefined variable error.
-