- Dec 02, 2020
-
-
Thomas Woerner authored
ipabackup: Fix undefined vars for conditions in shell tasks without else
-
- Dec 01, 2020
-
-
Thomas Woerner authored
The use of conditions in shell tasks without else clause is failing on some systems with an undefined variable error.
-
- Nov 30, 2020
-
-
Rafael Guterres Jeffman authored
utils/build-galaxy-release.sh: Fix default namespace and collection name
-
Rafael Guterres Jeffman authored
utils/changelog: Fix get_commit to use proper variable
-
Thomas Woerner authored
The default namespace and collection name was not set due to using ":" instead of "-" while setting the variables internally.
-
Thomas Woerner authored
The function get_commit was using the global merge variable instead of the local commit variable. Therefore it returned the wrong commit subject for merges without subject.
-
- Nov 27, 2020
-
-
Rafael Guterres Jeffman authored
ipareplica: Fix no_dnssec_validation handling in prepare and setup_dns
-
Thomas Woerner authored
The parameter options.no_dnssec_validation was set using a bad parameter name. This lead to not beeing able to turn off dnssec validation in the replica deployment. Fixes: #456 (ipareplica_no_dnssec_validation)
-
- Nov 26, 2020
-
-
Thomas Woerner authored
Fix ipahost module when adding hosts to a server without DNS support.
-
Thomas Woerner authored
ipasudocmdgroup: Fix creation of sudocmdgroups with sudocmds.
-
- Nov 25, 2020
-
-
Rafael Guterres Jeffman authored
ipa[server,replica]: Support memory check from command line installers
-
Rafael Guterres Jeffman authored
Remove an unused attribute that has no parallel in IPA API.
-
Rafael Guterres Jeffman authored
This PR fixes the creation of sudocmdgroups when the sudocmds are specified, allowing groups to be created with sudocmd members in a single task. Fix issue #440.
-
Rafael Guterres Jeffman authored
ipareplica README.md: Fix typo, add hidden replica parameter
-
Rafael Guterres Jeffman authored
ansible-doc-test: Ignore unhandled paths
-
Thomas Woerner authored
Currently the script is failing with The given path '...' is not valid if a path is not handled by the script. This is resulting in issues if module_utils and action plugins are updated for example. The solution is to simply ignore paths that are not handled.
-
Thomas Woerner authored
There was a typo in the README and also the ipareplica_hidden_replica parameter was missing.
-
Thomas Woerner authored
The common_check function in the replica installer code has been changed for the new memory checker code. With this the server and replica command line installers got the option --skip-mem-check. The server and replica role now also support the memory cheker and there are new variables for server and replica: ipaserver_mem_check - for ipaserver ipareplica_mem_check - for ipaserver These bool values default to yes and can be turned off in the inventory or playbook if needed. Related to freeipa PR https://pagure.io/freeipa/issue/8404 (Detect and fail if not enough memory is available for installation) Fixes: #450 (IPA Replica Installation Fails)
-
- Nov 24, 2020
-
-
Rafael Guterres Jeffman authored
Altough configuring DNS and KRA support on the testing server node provides broad coverage support, it does not represent all scenarios where ansible-freeipa can be used, for example without DNS support. This documentation updates removes the requirement for DNS and KRA support, and highlights what is expected with different configurations.
-
Rafael Guterres Jeffman authored
When using ipahost module with servers where DNS was not configured it failed to add hosts due to an exception raised on `dnsrecord_show` that was not being correctly handled. As the exception was being handled twice, the This patch simply removes one of the handlers, allowing the exception to propagate to the caller, where it is handled. Fixes issue #434.
-
- Nov 23, 2020
-
-
Thomas Woerner authored
Add CONTRIBUTING.md file.
-
Rafael Guterres Jeffman authored
This PR adds a document with information on how to contribute to ansible-freeipa development, showing the environment configuration, available tools, and some guidelines that should be followed.
-
Varun Mylaraiah authored
ipadnsforwardzone: Fix documentation for `forwarders` usage.
-
Thomas Woerner authored
Add pre-commit configuration for linters.
-
Varun Mylaraiah authored
ipadnszone: Fix modification o SOA serial with other attributes.
-
Varun Mylaraiah authored
ipadnsrecord: fix record update when multiple records exist.
-
- Nov 21, 2020
-
-
Rafael Guterres Jeffman authored
There was a failure when NAPTR or DLV records where updated, if the record name had multiple entries. This patch fixes this behavior, by using the requested record, not the retrieved one. Tests have been updated to test for this issue on tests/dnsrecord/test_dnsrecord.yml
-
- Nov 20, 2020
-
-
Rafael Guterres Jeffman authored
Due to an issue with FreeIPA, when modifying the SOA serial attribute along with other attributes, the value is ignored. In order to have the value provided, the attribute is set is a later call to dnszone-mod allowing it to retain the desired value. Ref: https://pagure.io/freeipa/issue/8489
-
Varun Mylaraiah authored
ipadnsrecord: fix record modification behavior.
-
- Nov 19, 2020
-
-
Rafael Guterres Jeffman authored
Examples of dnsforwarzone were using a single string rather than a dict of values to set attribute `forwarders`. Both source code and README examples were fixed. Fix issue #446
-
Rafael Guterres Jeffman authored
Fix lookup for certicates in tests
-
Thomas Woerner authored
The file lookup is by default setting `rstrip=True` which could lead into a stripped new line. This is not happening always but resulted in failed tests sometimes with certificates pasted to the b64encode filter. For calls of lookup in the certificae tests `rstrip=False` has been added to make sure that this is not happening any more. Not in test_dnsrecord as lookup(..., rstrip=False) is adding a new line if there was not a new line and this is an issue for dnsrecord. The user and host tests have also been simplified to create the base64 encoded file in the beginning and use this file then later on in the tests without the need to use the b64encode filter. Ref: https://github.com/ansible/ansible/issues/57521#issuecomment-502238000
-
Rafael Guterres Jeffman authored
ipaserver: copy_external_cert should use basename on server only
-
- Nov 18, 2020
-
-
Rafael Guterres Jeffman authored
README.md: Add missing roles and modules
-
Rafael Guterres Jeffman authored
This patch adds another lever of linter checking for ansible-freeipa by enabling linters to run on the developer machine, before pushing changes to be evaluated on the CI, allowing code fixes without wating for CI to run the linters on the repository. To enable pre-commit hooks, `pre-commit` is used, and was added to requirements-dev.txt, and can be installed with pip (`pip install -r requirements-dev.txt`). Once installed, on every commit, YAML and python files on the commit will be evaluated. If one needs to bypass the pre-commit linters, `git commit` can be issued with `--no-verify`. The linters will not be removed from the CI, as a commit can be performed without running the checks.
-
Rafael Guterres Jeffman authored
-
Rafael Guterres Jeffman authored
This change fixes retrieval of CERT values from server data, that was failing due to wrong attribute name.
-
Rafael Guterres Jeffman authored
When modifying a record, depending on how the playbook tasks were arranged, it was possible to end with more records than expected. This behavior was fixed by modifying the way records are searched when a modification is requested. This change also allows less calls find_dnsrecord. Tests were modified to reflect the changes, and a new test playbook was added: tests/dnsrecord/test_dnsrecord_modify_record.yml
-
Thomas Woerner authored
Currently the certifaictes are copied ot the server with the complete path that is provided within the playbook. This could result in unexpected file placements. Certificates should be placed in the /root folder for the deployment. Fixes #405 (copy_external_cert does not handle pathed items)
-
Thomas Woerner authored
Information about the backup role and also the config, delegation, dns config, location, permission, priviledge and self service modules have been missing in the main README file.
-