Skip to content
  1. Nov 24, 2023
  2. Nov 16, 2023
    • Thomas Woerner's avatar
      idoverride{user,group}: Fix delete_continue with state absent · 92e44f6a
      Thomas Woerner authored
      All tasks for idoverrideuser and idoverridegroup with state absent
      failed with "'continue' is required" when delete_continue was not set.
      
      This happended as delete_continue was internally None and continue: None
      was provided to the API.
      
      The fix is simply to use '"continue": delete_continue or False' so that
      continue is set to False in this case.
      92e44f6a
  3. Nov 11, 2023
    • Rafael Guterres Jeffman's avatar
      ipahost: Remove dangling dns records during test setup · 16c8ee87
      Rafael Guterres Jeffman authored
      When testing ipahost through the test playbooks, if there are previous
      DNS A/AAAA records, the test fails due to a false positive idempotence
      issue.
      
      This patch ensures that all DNS records for the test hosts are absent
      before test execution.
      
      This issue could be seen in the 2023-11-06 Azure Nightly pipeline
      execution.
      16c8ee87
  4. Nov 09, 2023
    • Rafael Guterres Jeffman's avatar
      utils/run-tests.sh: Replicate Azure's test grouping · 3109e9d1
      Rafael Guterres Jeffman authored
      When running ansible-freeipa's Azure pipelines for nightly and weekly
      tests, due to the amount of tests to execute, tests are grouped and
      executed in parallel jobs.
      
      Due to a still unkonwn issue, depending on the order the tests are
      executed, some random failures may occur and debugging them is hard due
      to current implementation of the tests.
      
      This patch adds support for replicating the tests of a specific Azure
      test group once the seed used to create groups and the group number are
      provided, allowing the test failures to be replicated on the developer's
      workstation where it can be more easily debugged.
      
      A new option is added to 'utils/run-tests.sh', '-A SEED.G' that is used
      to define the seed and group to replicate the tests. The seed is a date,
      with the format "YYYYMMDD", so, for example '-A 20230611.2' would
      execute the same tests, in the same order as the second group of tests
      for date 2023-06-11. To aid in usability 'YYYY-MM-DD' may also be used.
      
      When using '-A' neither '-s' (test suites) or specific tests (positional
      arguments) can be used.
      
      Also, to help fixing tests, an option to stop the tests on the first
      test failure ('-x') was added to the script.
      3109e9d1
  5. Nov 08, 2023
  6. Oct 23, 2023
  7. Oct 21, 2023
    • Thomas Woerner's avatar
      ipaidview: Fail to apply unknown (invalid) hosts · 21271949
      Thomas Woerner authored
      The task to apply an unknown (invalid) host to an idview was not failing
      as expected and only reported no change.
      
      A new host verification step has been added to fail before trying to
      apply invalid hosts. unapplying an invalid host is not failing as the
      invalid host is indeed not applied.
      21271949
    • Thomas Woerner's avatar
      hbacsvcgroup: Remove obsolete result_handler · 3de6f914
      Thomas Woerner authored
      The result_handler is not needed anymore as the idempotency issues with
      members have been fixed already for this module.
      
      Related: #685 hbacsvcgroup: Fix member management idempotence issues.
      3de6f914
    • Thomas Woerner's avatar
      hbacrule: Fix use of builtin sudo hbacsvcgroup · 48f2ef88
      Thomas Woerner authored
      hbacsvcgroup names are converted to lower case while creation with
      hbacsvcgroup_add.
      
      The hbacsvcgroup for sudo is builtin with the name "Sudo" though. This
      breaks the lower case comparison. Therefore all memberservice_hbacsvcgroup
      items are converted to lower case if "Sudo" is in the list.
      48f2ef88
  8. Oct 20, 2023
  9. Oct 19, 2023
    • Rafael Guterres Jeffman's avatar
      upstream ci: Run PR tests using a single job. · fe2d17e4
      Rafael Guterres Jeffman authored
      The usual scenario for PR checks is to execute only a few tests, and
      searching for the results in several jobs makes it harder to find
      issues.
      
      By using a single job run the tests would take some more time to
      complete, although not much, as only a small subset is executed, and
      test verification would be easier and less error prone.
      fe2d17e4
    • Rafael Guterres Jeffman's avatar
      upstream ci: Use a single random seed for spliting tests · 319a0d3d
      Rafael Guterres Jeffman authored
      Dependind on how long it took for the jobs to start, a different seed
      would be used to group tests and tests could either repeat or not be
      selected at all.
      
      By using a seed based on the day the test run reduces the chance of
      using different random seeds, and still allow for the tests to be
      executed in a different order.
      
      The execution in different order is important to identify tests that
      work or fail only if executed after other tests.
      319a0d3d
    • Rafael Guterres Jeffman's avatar
      upstream CI: Fix test selection for CheckPR pipeline. · c71a2b33
      Rafael Guterres Jeffman authored
      Due to an error on processing Ansible key 'import_tasks' the script that
      creates a list of modules to test is broken making some modules to be
      not tested.
      
      By fixing the handling of 'import_tasks' and module import, the list is
      correct again and the list of modules to be tested now include the ones
      which depend on the modified module.
      c71a2b33
    • Thomas Woerner's avatar
      Merge pull request #1159 from rjeffman/ci_pin_ansible_lint · 02223dfb
      Thomas Woerner authored
      upstream CI: Pin ansible-lint version to 6.20 series
      02223dfb
  10. Oct 18, 2023
  11. Oct 17, 2023
  12. Sep 27, 2023
  13. Sep 26, 2023
  14. Sep 25, 2023
  15. Sep 19, 2023
  16. Sep 18, 2023
    • Rafael Guterres Jeffman's avatar
      Merge pull request #1141 from t-woerner/new_idoverridegroup_module · fb75aed6
      Rafael Guterres Jeffman authored
      New idoverridegroup management module.
      fb75aed6
    • Thomas Woerner's avatar
      New idoverridegroup management module. · 6f5bb9ee
      Thomas Woerner authored
      There is a new idoverridegroup management module placed in the plugins
      folder:
      
          plugins/modules/ipaidoverridegroup.py
      
      The idoverridegroup module allows to ensure presence and absence of
      idoverrides for groups.
      
      Here is the documentation for the module:
      
          README-idoverridegroup.md
      
      New example playbooks have been added:
      
          playbooks/idoverridegroup/idoverridegroup-absent.yml
          playbooks/idoverridegroup/idoverridegroup-present.yml
      
      New tests for the module can be found at:
      
          tests/idoverridegroup/test_idoverridegroup.yml
          tests/idoverridegroup/test_idoverridegroup_client_context.yml
      6f5bb9ee
  17. Sep 16, 2023
  18. Sep 15, 2023
    • Thomas Woerner's avatar
      New idoverrideuser management module. · c0692e17
      Thomas Woerner authored
      There is a new idoverrideuser management module placed in the plugins
      folder:
      
          plugins/modules/ipaidoverrideuser.py
      
      The idoverrideuser module allows to ensure presence and absence of
      idoverrides for users and certificate members.
      
      Here is the documentation for the module:
      
          README-idoverrideuser.md
      
      New example playbooks have been added:
      
          playbooks/idoverrideuser/idoverrideuser-absent.yml
          playbooks/idoverrideuser/idoverrideuser-certificate-absent.yml
          playbooks/idoverrideuser/idoverrideuser-certificate-present.yml
          playbooks/idoverrideuser/idoverrideuser-present.yml
      
      New tests for the module can be found at:
      
          tests/idoverrideuser/test_idoverrideuser.yml
          tests/idoverrideuser/test_idoverrideuser_client_context.yml
      c0692e17
  19. Sep 14, 2023