Signed-off-by: Nils Philippsen <nils@redhat.com>

covscan error[SC2068]: Fix unquoted array expansions.

utils/gen_modules_docs.sh: Fix covscan findings

error[SC2068]: Double quote array expansions to avoid re-splitting elements.

utils/new_module: Fix covscan findings

utils/build-galaxy-release.sh: Fix covscan findings

error[SC2148]: Tips depend on target shell and yours is unknown.
  Add a shebang.

warning[SC2166]: Prefer [ p ] || [ q ] as [ p -o q ] is not well
  defined.

warning[SC2044]: For loops over find output are fragile. Use find -exec
  or a while read loop.
warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd
  fails.

yamllint: Run yaml linter only on modified files in pre-commit.

ipabackup: Fix undefined vars for conditions in shell tasks without else

The use of conditions in shell tasks without else clause is failing on
some systems with an undefined variable error.

utils/build-galaxy-release.sh: Fix default namespace and collection name

utils/changelog: Fix get_commit to use proper variable

The default namespace and collection name was not set due to using ":"
instead of "-" while setting the variables internally.

The function get_commit was using the global merge variable instead of
the local commit variable. Therefore it returned the wrong commit
subject for merges without subject.

ipareplica: Fix no_dnssec_validation handling in prepare and setup_dns

The parameter options.no_dnssec_validation was set using a bad
parameter name. This lead to not beeing able to turn off dnssec
validation in the replica deployment.

Fixes: #456 (ipareplica_no_dnssec_validation)

With the parameter `args: ['.']`, yamllint would run over every
file during pre-commit, including those not being commited, and it
would allow for false negatives, not allowing a commit, even if
commited yaml files had no issues, but another file, not par of the
commit, had.

By changing the yamllint parameter to `files: \.(yaml|yml)$` it
will only check files being commited, preventing false negatives,
and allowing for faster commits.

Fix ipahost module when adding hosts to a server without DNS support.

ipasudocmdgroup: Fix creation of sudocmdgroups with sudocmds.

ipa[server,replica]: Support memory check from command line installers

Remove an unused attribute that has no parallel in IPA API.

This PR fixes the creation of sudocmdgroups when the sudocmds are
specified, allowing groups to be created with sudocmd members in a
single task.

Fix issue #440.

ipareplica README.md: Fix typo, add hidden replica parameter

ansible-doc-test: Ignore unhandled paths

Currently the script is failing with The given path '...' is not valid
if a path is not handled by the script. This is resulting in issues if
module_utils and action plugins are updated for example.

The solution is to simply ignore paths that are not handled.

There was a typo in the README and also the ipareplica_hidden_replica
parameter was missing.

The common_check function in the replica installer code has been changed
for the new memory checker code. With this the server and replica command
line installers got the option --skip-mem-check.

The server and replica role now also support the memory cheker and there
are new variables for server and replica:

    ipaserver_mem_check - for ipaserver
    ipareplica_mem_check - for ipaserver

These bool values default to yes and can be turned off in the inventory
or playbook if needed.

Related to freeipa PR https://pagure.io/freeipa/issue/8404 (Detect and
fail if not enough memory is available for installation)

Fixes: #450 (IPA Replica Installation Fails)

Altough configuring DNS and KRA support on the testing server node
provides broad coverage support, it does not represent all scenarios
where ansible-freeipa can be used, for example without DNS support.

This documentation updates removes the requirement for DNS and KRA
support, and highlights what is expected with different configurations.

When using ipahost module with servers where DNS was not configured
it failed to add hosts due to an exception raised on `dnsrecord_show`
that was not being correctly handled.

As the exception was being handled twice, the This patch simply removes
one of the handlers, allowing the exception to propagate to the caller,
where it is handled.

Fixes issue #434.

Add CONTRIBUTING.md file.

This PR adds a document with information on how to contribute to
ansible-freeipa development, showing the environment configuration,
available tools, and some guidelines that should be followed.

ipadnsforwardzone: Fix documentation for `forwarders` usage.

Add pre-commit configuration for linters.

ipadnszone: Fix modification o SOA serial with other attributes.

ipadnsrecord: fix record update when multiple records exist.

There was a failure when NAPTR or DLV records where updated,
if the record name had multiple entries. This patch fixes this
behavior, by using the requested record, not the retrieved one.

Tests have been updated to test for this issue on

    tests/dnsrecord/test_dnsrecord.yml

Due to an issue with FreeIPA, when modifying the SOA serial attribute
along with other attributes, the value is ignored. In order to have
the value provided, the attribute is set is a later call to dnszone-mod
allowing it to retain the desired value.

Ref: https://pagure.io/freeipa/issue/8489

ipadnsrecord: fix record modification behavior.